Repository navigation
Bind plugin hook approval to plugin contents - #54619
Merged
copyberry[bot] merged 1 commit intoOct 16, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why A plugin's scripts can change without changing its hook declaration. Declaration-only approval therefore lets changed plugin code run under an existing hook approval. ## What changed - Fingerprint plugin bundle contents and include the content hash in the approval value returned by `hooks/list`. Persist it as `trusted_content_hash`, keeping `trusted_hash` compatible with older clients. - Verify contents before each command or MCP hook execution, within the hook's timeout, and require renewed approval when approved contents change. - Migrate legacy declaration-only approvals to a shared, immutable content baseline per plugin and config home. - Exclude generated Python bytecode, `.venv`, and `.egg-info` entries from fingerprints. Run app-server hook listing on blocking tasks. ## Testing Extend integration coverage for plugin upgrades and rollbacks requiring approval, same-turn script changes preventing further hook execution, shared legacy approval baselines, and generated Python artifacts preserving trust. GitOrigin-RevId: faaf7658210d8adb2534ddd614c72ec993920840
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/faaf7658210d8adb2534ddd614c72ec993920840
branch
from
October 16, 2026 14:38
8ebca31 to
2bf2bdf
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/faaf7658210d8adb2534ddd614c72ec993920840
branch
October 16, 2026 14:38
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
silverlane-jkh
temporarily deployed
to
issue-triage
October 16, 2026 14:39 — with
GitHub Actions
Inactive
silverlane-jkh
temporarily deployed
to
issue-triage
October 16, 2026 14:39 — with
GitHub Actions
Inactive
silverlane-jkh
temporarily deployed
to
issue-triage
October 16, 2026 14:39 — with
GitHub Actions
Inactive
jasethefacee
temporarily deployed
to
issue-triage
October 16, 2026 14:44 — with
GitHub Actions
Inactive
jasethefacee
temporarily deployed
to
issue-triage
October 16, 2026 14:44 — with
GitHub Actions
Inactive
jasethefacee
temporarily deployed
to
issue-triage
October 16, 2026 14:44 — with
GitHub Actions
Inactive
1129678576
temporarily deployed
to
issue-triage
October 16, 2026 14:46 — with
GitHub Actions
Inactive
1129678576
temporarily deployed
to
issue-triage
October 16, 2026 14:46 — with
GitHub Actions
Inactive
1129678576
temporarily deployed
to
issue-triage
October 16, 2026 14:46 — with
GitHub Actions
Inactive
1129678576
temporarily deployed
to
issue-triage
October 16, 2026 14:47 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bind plugin hook approval to plugin contents
Why
A plugin's scripts can change without changing its hook declaration. Declaration-only approval therefore lets changed plugin code run under an existing hook approval.
What changed
hooks/list. Persist it astrusted_content_hash, keepingtrusted_hashcompatible with older clients..venv, and.egg-infoentries from fingerprints. Run app-server hook listing on blocking tasks.Testing
Extend integration coverage for plugin upgrades and rollbacks requiring approval, same-turn script changes preventing further hook execution, shared legacy approval baselines, and generated Python artifacts preserving trust.