Updating make-me-say to be compatible with Solvers#1546
Open
lennart-finke wants to merge 5 commits intoopenai:mainfrom
Open
Updating make-me-say to be compatible with Solvers#1546lennart-finke wants to merge 5 commits intoopenai:mainfrom
lennart-finke wants to merge 5 commits intoopenai:mainfrom
Conversation
danesherbs
reviewed
Aug 22, 2024
danesherbs
reviewed
Aug 22, 2024
danesherbs
reviewed
Aug 22, 2024
danesherbs
reviewed
Aug 22, 2024
Author
|
Thanks for the comments @danesherbs! Addressed them and reran tests, ready for further review or merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors make-me-say to be compatible with the Solvers API.
Instead of passing three completion functions, the eval is now passed one solver as the con artist and two completion functions as the mark and summary model respectively.
We still assume(Edit: Reviewer suggested addinggpt-4-32kandgpt-3.5-turbo-16kas defaults, as #1530 is not yet merged.gpt-4o-minias default instead and changing the registry ourselves.)Submission agreement
By contributing to Evals, you are agreeing to make your evaluation logic and data under the same MIT license as this repository. You must have adequate rights to upload any data used in an Eval. OpenAI reserves the right to use this data in future service improvements to our product. Contributions to OpenAI Evals will be subject to our usual Usage Policies (https://platform.openai.com/docs/usage-policies).