Add implementation of AdvancedSQLAlchemy#2041
Closed
DanieleMorotti wants to merge 2 commits intoopenai:mainfrom
Closed
Add implementation of AdvancedSQLAlchemy#2041DanieleMorotti wants to merge 2 commits intoopenai:mainfrom
DanieleMorotti wants to merge 2 commits intoopenai:mainfrom
Conversation
Member
|
Quick update on this: We may revisit some details of the existing advanced session behaviors, so let us hold off considering this. |
Contributor
Author
|
Okay, let me know if I can be of any help |
Contributor
|
@DanieleMorotti @seratch Do we have some updates regarding this? I was building my own version of AdvancedSQLAlchemySession when i stumbled on this PR |
Contributor
Author
|
I have no news since @seratch’s last comment. I think they will review it as soon as they can |
Contributor
|
This PR is stale because it has been open for 10 days with no activity. |
Contributor
|
This PR is stale because it has been open for 10 days with no activity. |
Contributor
|
This PR was closed because it has been inactive for 7 days since being marked as stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature
This PR introduces the
AdvancedSQLAlchemySession, adapted from the existingAdvancedSQLLiteSessionimplementation to work withSQLAlchemy. Related to #2035 .The new class aims to provide feature parity with
AdvancedSQLLiteSession, including support for usage tracking, branching, and other existing functionalities.Testing
For testing, I’ve replicated and adjusted the test cases from
AdvancedSQLLiteSessionto ensure similar coverage and behavior.Let me know if this seems like a solid starting point or if there are some problems!