Skip to content

fix(internal): restrict isAbsoluteURL scheme regex to http(s) #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ibondarenko1 wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −1
Open

fix(internal): restrict isAbsoluteURL scheme regex to http(s) #1888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/internal/utils/values.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,13 @@
import { OpenAIError } from '../../core/error';

// https://url.spec.whatwg.org/#url-scheme-string
const startsWithSchemeRegexp = /^[a-z][a-z0-9+.-]*:/i;
//
// Restricted to http(s) to avoid bypassing baseURL through dangerous schemes
// (file:, gopher:, ftp:, data:, javascript:) when an absolute-URL path is
// passed to client.get / client.post. The SDK's typed resource methods use
// hardcoded relative paths, so this narrows the regex to the only schemes
// the SDK is meant to construct outbound requests against.
const startsWithSchemeRegexp = /^https?:/i;

export const isAbsoluteURL = (url: string): boolean => {
return startsWithSchemeRegexp.test(url);
Expand Down