This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Merged
Conversation
tomkrouper
approved these changes
Sep 29, 2020
Collaborator
tomkrouper
left a comment
tomkrouper
left a comment
There was a problem hiding this comment.
Thanks so much. Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1245
This PR expires
cluster_aliasentries, based onUnseenInstanceForgetHours, same asdatabase_instanceentries are expired.The effect is that
orchestratorproperly forgets aliases for clusters that have no instances (ie. created long ago, but which have probably been decomissioned, seeing that there's no instances that associate themselves with said alias).cc @tomkrouper