This repository was archived by the owner on Feb 18, 2025. It is now read-only.
add replication delay command#1267
Merged
shlomi-noach merged 8 commits intoopenark:masterfrom Nov 19, 2020
Merged
Conversation
shlomi-noach
suggested changes
Nov 17, 2020
Collaborator
shlomi-noach
left a comment
There was a problem hiding this comment.
Thank you! This looks good, with a few requests for changes. Please consider adding a delay-replication command in https://github.com/openark/orchestrator/blob/master/resources/bin/orchestrator-client
Contributor
Author
|
@shlomi-noach I added the modifications you suggested. Thank you for the review. |
shlomi-noach
approved these changes
Nov 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #1266
Description
This PR adds a command to delay replication on a specific instance keeping the current replication threads status.
Please make sure that:
Please make sure the PR passes CI tests. For your information, CI tests the following:
gofmt(please avoidgoimports)masterbranch) is successful