TASK-7524 - Add new Variant output format: JSON_SPARSE#109
Merged
jtarraga merged 3 commits intorelease-6.x.xfrom Jun 14, 2025
Merged
TASK-7524 - Add new Variant output format: JSON_SPARSE#109jtarraga merged 3 commits intorelease-6.x.xfrom
jtarraga merged 3 commits intorelease-6.x.xfrom
Conversation
Member
|
Task linked: TASK-7524 Add new Variant output format: JSON_SPARSE |
There was a problem hiding this comment.
Pull Request Overview
This PR tackles TASK-7524 by adding a new test for the Command class, deprecating SingleProcess, and refactoring the Command class to use asynchronous stream reading via Futures.
- Added CommandTest.java to validate execution and output handling of Command
- Marked SingleProcess as deprecated
- Updated Command.java to use an ExecutorService for stream reading and added a getStdin() method
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| commons-lib/src/test/java/org/opencb/commons/exec/CommandTest.java | Added tests to verify command execution and output correctness |
| commons-lib/src/main/java/org/opencb/commons/exec/SingleProcess.java | Deprecated the SingleProcess class |
| commons-lib/src/main/java/org/opencb/commons/exec/RunnableProcess.java | Initialized status to WAITING for improved state management |
| commons-lib/src/main/java/org/opencb/commons/exec/NamedThreadFactory.java | No functional changes |
| commons-lib/src/main/java/org/opencb/commons/exec/Command.java | Refactored to use asynchronous stream reading with Futures and added a new getStdin() accessor |
Comments suppressed due to low confidence (1)
commons-lib/src/main/java/org/opencb/commons/exec/Command.java:208
- The log formatting appears incorrect; consider updating it to: logger.trace(outputName + " - last bytesRead = {}", bytesRead);
logger.trace(outputName + " - last bytesRead = {})", bytesRead);
pfurio
approved these changes
May 15, 2025
pfurio
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.