initializer: add RegisterWithSource to allow pass in dataSourceName to sql.Open #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrveera
changed the title
odeke-em
requested changes
May 18, 2020
Member
odeke-em
left a comment
odeke-em
left a comment
There was a problem hiding this comment.
Thank you for this change @veera83372 and for filling the bug.
LGTM with some minor nits. However, could you please update your commit message,
and this PR subject and message as well to the following:
initializer: add RegisterWithSource to allow pass in dataSourceName to sql.Open
Adds an initializing function RegisterWithSource that allows the dataSourceName to
be passed into database/sql.Open. This option is important for backends such as
goracle and godor, lest they return an initialization error.
Fixes #41…o sql.Open Adds an initializing function RegisterWithSource that allows the dataSourceName to be passed into database/sql.Open. This option is important for backends such as goracle and godor, lest they return an initialization error. Fixes opencensus-integrations#41
mrveera
changed the title
odeke-em
approved these changes
Dec 1, 2020
Member
odeke-em
left a comment
odeke-em
left a comment
There was a problem hiding this comment.
LGTM, thank you @veera83372!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an initializing function RegisterWithSource that allows the dataSourceName to
be passed into database/sql.Open. This option is important for backends such as
goracle and godor, lest they return an initialization error.
Fixes #41