Custom outputting for pupa data#299
Closed
doubleswirve wants to merge 81 commits into
Closed
Conversation
… pass json key file into build)
Custom export update
…date meta data from google pubsub as it is already part of the message object (during subscription)
… client just once in __init__
Google Pub/Sub env var adjustments and helper methods
Custom export amazon sqs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologies if this is a little rough around the edges (not sure what the etiquette is on some of this stuff), but I wanted to submit this as a work-in-progress PR to get feedback.
This PR allows pupa data to be sent to other targets besides being written to a file. This initially includes an output option for Google Cloud Pub/Sub (thanks @showerst for initial implementation), but could also be extended to additional targets/services (e.g., Kafka).
The basic idea is we hook into the
__init__method of theScraperclass, and set up an instance variableoutput_target(which defaults toselffor the default file writing). Based on the specifiedOUTPUT_TARGETenvironment variable, we call thesave_objectmethod on either the defaultScraperinstance or the alternative output target instance (e.g., Pub/Sub instance). So the only requirement is to have the alternative output target class implement asave_objectmethod.So far this works pretty well; however, a couple redundant spots include:
obj.pre_savecallobj.validate())obj._relatediterating/savingSeems like some of these could be moved to methods in the
Scraperclass so alternative output target classes wouldn't need to include them.We probably need some unit testing in there as well. Anyway, open to ideas and look forward to getting your feedback. Thanks!