Skip to content
This repository was archived by the owner on Jun 1, 2026. It is now read-only.

Decrease org-wide default for stalebot - #13

Closed
lelia wants to merge 4 commits into
mainfrom
stalebot-org-default
Closed

lelia wants to merge 4 commits into
mainfrom
stalebot-org-default

Conversation

@lelia

@lelia lelia commented May 18, 2023

Copy link
Copy Markdown
Contributor

As discussed, let's dial the org-wide StaleBot defaults down, and allow individual projects to override these settings at the repository level, should they need them to be less (or more) aggressive.

@lelia
lelia requested a review from a team as a code owner May 18, 2023 18:56

@shmcfarl shmcfarl left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread .github/stale.yml
# closeComment: >
# Your comment here.
This stale issue is now closed due to inactivity. Please re-open or re-file if
if the issue is still relevant. Thank you!

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this message is missing the comment #s so it'll probably end up being tacked onto the end of the markComment. We also updated the messaging in the vmclarity/kubeclarity repo so there was a bit more info about a) what the criteria for stale was
b) when its likely to be closed.
https://github.com/openclarity/kubeclarity/blob/main/.github/stale.yml#L30-L44

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch with the comment # - that's what I get for quickly copying config from one repo into another :D

I used some of the KubeClarity stalebot messaging as inspiration for creating this PR (see also openclarity/kubeclarity#432). As far as hardcoding the 'number of days' until stale/closed, my concern with baking that into the message text in our .github repository default means it's likely someone will forget to update the values in multiple places (the idea with this PR is that we introduce a more aggressive default setting, but encourage maintainers to override with their own values as needed). Thoughts?

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to fix the closeComment section before we can merge this

@lelia

lelia commented May 23, 2023

Copy link
Copy Markdown
Contributor Author

Closing in favor of #14

@lelia lelia closed this May 23, 2023
@lelia
lelia deleted the stalebot-org-default branch June 2, 2023 19:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants