Skip to content

Conversation

@TheOneRing
Copy link
Contributor

Fixes: #261

@TheOneRing TheOneRing force-pushed the work/global_settings branch 5 times, most recently from 2384c61 to fb9096e Compare May 20, 2025 14:08
@TheOneRing TheOneRing requested a review from Copilot May 21, 2025 08:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new GlobalConfig utility to read preconfigured server URLs (and other settings) from system/global policy sources, removing the old Theme-based overrides and postfix logic.

  • Remove overrideServerUrl() and wizardUrlPostfix() from Theme
  • Add GlobalConfig::serverUrl() and policy‐reading functions
  • Update ConfigFile, wizard pages, and enums to use GlobalConfig instead of theme overrides

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/libsync/theme.h / theme.cpp Removed server‐URL override and wizard URL postfix methods
src/libsync/globalconfig.h / globalconfig.cpp Added GlobalConfig class for system/policy config access
src/libsync/configfile.h / configfile.cpp Refactored policy and value lookup to delegate to GlobalConfig
src/libsync/CMakeLists.txt Added globalconfig.cpp to build
src/gui/newwizard/pages/serverurlsetupwizardpage.cpp Switched to GlobalConfig::serverUrl() and removed theme calls
src/gui/newwizard/enums.cpp Updated wizard state display logic to use GlobalConfig
Comments suppressed due to low confidence (1)

src/libsync/globalconfig.cpp:17

  • Consider adding unit tests for GlobalConfig::getValue (and getPolicySetting on Windows) to verify correct fallback behavior across different OS paths.
QVariant GlobalConfig::getValue(QAnyStringView param, const QVariant &defaultValue)

@TheOneRing TheOneRing force-pushed the work/global_settings branch from d891854 to 0806711 Compare May 21, 2025 08:55
@TheOneRing TheOneRing merged commit f25987e into main May 21, 2025
3 checks passed
@TheOneRing TheOneRing deleted the work/global_settings branch May 21, 2025 11:04
@openclouders openclouders mentioned this pull request May 21, 2025
1 task
@openclouders openclouders mentioned this pull request Jun 12, 2025
1 task
@openclouders openclouders mentioned this pull request Jun 25, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Read preconfigured server urls

1 participant