Folder watcher: ignore changes in short lived files#455
Merged
TheOneRing merged 5 commits intomainfrom Aug 6, 2025
Merged
Conversation
TheOneRing
force-pushed
the
work/watcher
branch
3 times, most recently
from
d67d9a7 to
408e9d5
Compare
TheOneRing
force-pushed
the
work/watcher
branch
from
408e9d5 to
bb45ea1
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements logic to ignore changes in short-lived files by enhancing the folder watcher's handling of temporary files that appear and disappear quickly. It aims to reduce unnecessary processing of transient files that don't need to be synchronized.
- Enhanced detection and filtering of temporary files that no longer exist when processed
- Improved error handling for file name conversion in Windows folder watcher
- Added proper enum types for Windows file change actions to improve type safety
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/libsync/csync_exclude.cpp | Fixed desktop.ini exclusion pattern and added assertion for non-empty relative paths |
| src/gui/folderwatcher_win.h | Added ChangeAction enum for Windows file system events |
| src/gui/folderwatcher_win.cpp | Refactored file change processing with better error handling and temporary file detection |
| src/gui/folderwatcher.cpp | Added logic to ignore changes for non-existent files unless they're tracked in the journal |
TheOneRing
force-pushed
the
work/watcher
branch
from
2ac2411 to
db56c01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.