validator: Relax warning for not abs mount dst path#4013
Merged
lifubang merged 1 commit intoopencontainers:mainfrom Sep 12, 2023
Merged
validator: Relax warning for not abs mount dst path#4013lifubang merged 1 commit intoopencontainers:mainfrom
lifubang merged 1 commit intoopencontainers:mainfrom
Conversation
The runtime spec now allows relative mount dst paths, so remove the comment saying we will switch this to an error later and change the error messages to reflect that. Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
AkihiroSuda
approved these changes
Sep 12, 2023
lifubang
approved these changes
Sep 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runtime spec now allows relative mount dst paths, so remove the comment saying we will switch this to an error later and change the error messages to reflect that.
This was changed in this runtime-spec PR: opencontainers/runtime-spec#1225
I'm not 100% sure this new text is good, but invalid configuration seemed strong now. If you have better suggestions, please share them! :)