tests/int/checkpoint: drop unneeded tests#5222
Open
kolyshkin wants to merge 1 commit intoopencontainers:mainfrom
Open
tests/int/checkpoint: drop unneeded tests#5222kolyshkin wants to merge 1 commit intoopencontainers:mainfrom
kolyshkin wants to merge 1 commit intoopencontainers:mainfrom
Conversation
Those tests were added by commit 8d180e9 ("Add support for Linux Network Devices"), apparently by copy-pasting the test cases which call simple_cr (all four of them). While different simple_cr tests make sense as they cover different code paths in runc and/or check for various regression, the same variations with netdevice do not make sense, as having a net device is orthogonal to e.g. bind mount, --debug, or cgroupns. Remove those. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Contributor
|
/lgtm I can't remember but I assume my ignorance thought those were different code paths somehow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those tests were added by commit 8d180e9 ("Add support for Linux Network Devices"), apparently by copy-pasting the test cases which call simple_cr (all four of them).
While different simple_cr tests make sense as they cover different code paths in runc and/or check for various regression, the same variations with netdevice do not make sense, as having a net device is orthogonal to e.g. bind mount, --debug, or cgroupns.
Remove those.
Cc: @aojea