tests: remove --console usage#883
Closed
cyphar wants to merge 1 commit intoopencontainers:masterfrom
cyphar:tests-remove-console-usage
Closed
tests: remove --console usage#883cyphar wants to merge 1 commit intoopencontainers:masterfrom cyphar:tests-remove-console-usage
cyphar wants to merge 1 commit intoopencontainers:masterfrom
cyphar:tests-remove-console-usage
Conversation
Member
Author
|
The failures are because it looks like /cc @crosbymichael |
Member
|
looking |
The previous usage of --console was very misleading, and is not how the flag should be used by users. In addition, due to other bugs and design issues, --console does not work in user namespaces. By removing --console usage in the tests, we can now (in principle) run all of the tests in user namespaces. Signed-off-by: Aleksa Sarai <asarai@suse.de>
Member
Author
|
Superceded by #1018. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous usage of --console was very misleading, and is not how the
flag should be used by users. In addition, due to other bugs and design
issues, --console does not work in user namespaces. By removing
--console usage in the tests, we can now (in principle) run all of the
tests in user namespaces.
Signed-off-by: Aleksa Sarai asarai@suse.de