Skip to content

schema: fix schema for timeOffsets #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrunalp merged 1 commit into from
Mar 31, 2023
Merged

schema: fix schema for timeOffsets #1193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions schema/config-linux.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,8 +283,14 @@
},
"timeOffsets": {
"type": "object",
"additionalProperties": {
"$ref": "defs-linux.json#/definitions/TimeOffsets"
"type": "object",
Copy link
Contributor

@cbandy cbandy Apr 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This inadvertently duplicates the type key. See #1195.

"properties": {
"boottime": {
"$ref": "defs-linux.json#/definitions/TimeOffsets"
Copy link
Member

@utam0k utam0k Mar 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a reviewer, but since I went through the trouble of checking, I will leave a comment to make it easier for other reviewers to check.
36bb632#diff-d1de2574b4882bd4de1fec3238c90fd13a4ee8ce8142644ff82a5eb0d76cf69aR313-R322

},
"monotonic": {
"$ref": "defs-linux.json#/definitions/TimeOffsets"
}
}
}
}
Expand Down