add systemd-nspawn to implementations.md#1272
Conversation
Artoria2e5
requested review from
AkihiroSuda,
crosbymichael,
cyphar,
dqminh,
giuseppe,
hqhq,
kolyshkin,
mrunalp,
thaJeztah,
tianon and
utam0k
as code owners
|
AFAICS systemd-nspawn does not implement this spec. |
Therefore this should be closed (unless I'm missing something). |
Implements: https://github.com/systemd/systemd/blob/main/src/nspawn/nspawn-oci.c |
|
My bad, indeed, |
kolyshkin
left a comment
kolyshkin
left a comment
There was a problem hiding this comment.
My bad, indeed,
systemd-nspawnimplements--oci-bundleoption since systemd v242.
So it would be nice to mention the above option and the version number, otherwise LGTM.
ping @Artoria2e5 |
|
ping @Artoria2e5 |
|
It reads a bundle (config.json, rootfs, etc.) but it doesn't seem to implement any of the subcommands (like features, list, etc.) and IIRC it's not a full spec or at the very least is an old spec what it implements (I think the former, not the full spec, of some old version of the spec). |
|
Please squash the commits |
|
@Artoria2e5 please squash the commits. |
It's a bit awkward really, since that nspawn isn't the WHOLE repo on GitHub unlike the others... Signed-off-by: Mingye Wang <arthur200126@gmail.com>
|
Ah sorry! done. |
4 participants
It's a bit awkward really, since that nspawn isn't the WHOLE repo on GitHub unlike the others...