Repository navigation
fix(security): hono 4.13.11 -> 4.13.16 (CVE-2026-126355) +11 more - #524
Open
leoisadev1 wants to merge 2 commits into
Open
leoisadev1 wants to merge 2 commits into
leoisadev1 wants to merge 2 commits into
Conversation
…asic-ftp to 6.2.4 Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
[Medium impact] The PR appears safe to merge; no actionable new defects were found. SummaryUpdates dependency versions intended to address published advisories.
No actionable new issues were found. Checks were limited to source and dependency metadata; no builds or tests were run. Reviews (2) · Last reviewed commit: "fix(security): move astro to 7.4.7 and @..." · Reviewed by Greptile |
…-http to 0.222.0 Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The root lockfile resolved hono 4.13.11, @hono/node-server 2.1.3 and basic-ftp 6.2.1, which are affected by nine advisories published on Nov 12. All three are transitive (under the MCP SDK packages,
@mastra/*andget-uri) and were already held by root overrides inpnpm-workspace.yaml. This PR raises those three overrides to the lowest fixed releases, bounds them on both sides, and regeneratespnpm-lock.yaml. A second commit covers the advisories published on Nov 13 and 14: it moves the marketing site's astro from 7.3.3 to 7.4.7 directly, and pins @opentelemetry/instrumentation-http (under@daytona/sdk) to 0.222.0 with a new bounded override.Why this way: a plain lockfile refresh can't move these packages because the existing
<4.13.11,<2.1.3and<6.2.1overrides pin them. Raising the overrides the repo already uses keeps one source of truth, and it doesn't add a second override next to the first.Door: two-way · Risk: low (composes root dependency overrides) · Cleanup: none
I checked each fixed version on cve.now and in its GHSA. None is in KEV, and no public exploit is tracked.
Files changed:
pnpm-workspace.yaml(three overrides),pnpm-lock.yaml, and.changeset/hono-node-server-basic-ftp-advisories.md(akeru-botpatch, because CI requires a changeset decision). The lower bounds keep the earlier behavior:get-uriasks for basic-ftp ^5.0.2 and@modelcontextprotocol/nodeasks for @hono/node-server ^1.19.9, and both were already forced onto the newer major before this PR. basic-ftp has no fixed 5.x release.@daytona/sdk0.207.0 asks for instrumentation-http^0.221.0, which on a 0.x line means below 0.222.0, so only an override can reach the fix. 0.222.0 brings its own exact @opentelemetry/core 2.11.0 and @opentelemetry/instrumentation 0.222.0. Its only peer is @opentelemetry/api ^1.3.0, so the rest of Daytona's OpenTelemetry stack (sdk-node 0.221.0, core 2.10.0) stays where it is. The astro move also pulls in astro 7.4.7's own dependency ranges: rolldown 1.3.2, the 0.5.3 compiler bindings and shiki 4.6.0. That moves @shikijs/themes from 4.5.0 to 4.6.0 for @pierre/diffs. The akeru-bot app doesn't use @astrojs/node, so CVE-2026-126364's adapter path doesn't apply here.Evidence
csrf()accept a cross-originPOSTwithContent-Type: text/ping(CVE-2026-126355): HTTP 200.After: the same request against the installed hono 4.13.16 returns HTTP 403.
pnpm-lock.yamlnow holds only hono 4.13.16, @hono/node-server 2.1.6, basic-ftp 6.2.4, astro 7.4.7 and instrumentation-http 0.222.0, with no older copy. The only other lockfile change is a refreshed deprecation message on two@smithy/coreentries, which is registry metadata only.The 7 server failures are git-remote tests in
RepositoryIdentityResolver.test.tsandGitStatus.test.ts. They fail the same way on main in this sandbox and pass in GitHub CI.I didn't run the Rust resource-monitor steps, because this PR touches no Rust code.
GitHub CI: Server tests (4/4) fails
026_CanonicalizeModelSelectionOptions.test.ts > converts legacy object-shape options into array-shape on projections and events, where one project row'soptionsstays a JSON string. The same test fails in the 11-12 release-PR run built from main (run 43165691057, Server tests 4/4), and it passes locally on both main and this branch. That makes it a main-side failure that this PR doesn't touch. A rerun failed the same way.An independent GPT-6.1 Sol review (medium effort) found no issues in the first commit. On the second commit it flagged unrelated lockfile churn: needle's sax 1.6.0 -> 1.6.1 and Expo optional-peer hashes. I reverted those hunks,
pnpm install --frozen-lockfilestill passes, and a second Sol pass found no issues.Not checked: live span capture through Daytona's tracer. My local probe recorded no spans on main either, so it can't tell the two versions apart.
Merge Danger
This is two-way: reverting the commit restores the previous overrides and lockfile. The riskiest part is hono 4.13.16's stricter middleware and router behavior under the MCP HTTP transports.
Blast radius: MCP server and client transports, and the FTP path through
get-uri. Akeru code doesn't import hono, @hono/node-server or basic-ftp directly.Not fixed here: vendored
.repos/*lockfiles, which are read-only. Open #364 adds hono ^4.13.0 to a new package; once it rebases, the override resolves that to 4.13.16.Created with Claude Opus 5.5 in Capy.