Skip to content
This repository was archived by the owner on Apr 14, 2026. It is now read-only.

feat: return the display name of the section and subsection of each unit#68

Merged
farhan merged 2 commits intoopenedx:masterfrom
eduNEXT:bav/show-parents-display-name
Mar 23, 2024
Merged

feat: return the display name of the section and subsection of each unit#68
farhan merged 2 commits intoopenedx:masterfrom
eduNEXT:bav/show-parents-display-name

Conversation

@BryanttV
Copy link
Copy Markdown
Contributor

@BryanttV BryanttV commented Mar 15, 2024

Description

This PR returns the display name of the section and subsection for each unit in the reporting table in the instructor dashboard tab. This change allows the instructor to more easily identify which component is being displayed in the table.

Screenshots

Before

image

After

image

Testing Instructions

  1. In your environment add the following setting, you can use this inline-plugin:

    name: feedback-xblock-settings
    version: 0.1.0
    patches:
      openedx-common-settings: |
        FEATURES["ENABLE_FEEDBACK_INSTRUCTOR_VIEW"] = True
        OPEN_EDX_FILTERS_CONFIG = {
          "org.openedx.learning.instructor.dashboard.render.started.v1": {
            "fail_silently": False,
            "pipeline": [
              "feedback.extensions.filters.AddFeedbackTab",
            ]
          },
        }
        
  2. From Studio, in your course > Advanced Settings > Advanced Module List > add "feedback" in the list.

  3. In your course add a feedback component.

  4. From LMS, answer the feedback component as a student or instructor.

  5. Go to the Instructor Dashboard:

    image

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 15, 2024
@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @BryanttV! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@BryanttV BryanttV force-pushed the bav/show-parents-display-name branch from 5ce2ac4 to 8338772 Compare March 15, 2024 18:35
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.47%. Comparing base (65e32f3) to head (9104c42).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
+ Coverage   92.41%   92.47%   +0.06%     
==========================================
  Files           5        5              
  Lines         224      226       +2     
==========================================
+ Hits          207      209       +2     
  Misses         17       17              
Flag Coverage Δ
unittests 92.47% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely looks better. Thank you!

@BryanttV BryanttV requested review from farhan and feanil March 19, 2024 17:49
@BryanttV
Copy link
Copy Markdown
Contributor Author

Hi folks @feanil @farhan! I have mentioned you here and you have already reviewed some PRs. Please could you take a look at these changes, thanks!

@mariajgrimaldi
Copy link
Copy Markdown
Member

@feanil: could you help us merge this PR too? Thanks!

Comment thread feedback/static/html/feedback_instructor.html
@BryanttV BryanttV requested a review from farhan March 22, 2024 15:54
@farhan
Copy link
Copy Markdown
Contributor

farhan commented Mar 23, 2024

Looks great!
Thanks for the contribution ⭐

@farhan farhan merged commit 6450d92 into openedx:master Mar 23, 2024
@openedx-webhooks
Copy link
Copy Markdown

@BryanttV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project
Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants