fix: aggregated vote value is not updated till refresh#83
Hidden character warning
Conversation
|
Thanks for the pull request, @ihor-romaniuk! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #83 +/- ##
==========================================
+ Coverage 92.37% 92.76% +0.38%
==========================================
Files 5 5
Lines 223 221 -2
==========================================
- Hits 206 205 -1
+ Misses 17 16 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@openedx/axim-engineering - is this something we can review / merge? |
feanil
left a comment
There was a problem hiding this comment.
@ihor-romaniuk this PR mixes styling changes with the actual changes you're trying to make, happy to take them both but I think they should be atleast separate commits so that it's easier to review the technical changes. Can you either split them or remove the style changes so that it's easier to review the logical change?
|
Hi @ihor-romaniuk! Just checking to see if this is still in-progress? |
|
Friendly ping on this, @ihor-romaniuk! |
ee0bc9e to
40e5cad
Compare
40e5cad to
f4a3ac7
Compare
|
@feanil Thanks for your comment. |
feanil
left a comment
There was a problem hiding this comment.
@ihor-romaniuk change makes sense, and it's nice to reduce duplicate here for the scale html. Can you bump the version and then I can merge and make a new release.
|
@feanil I updated version and it's ready for final review. Thanks. |
|
Thanks @ihor-romaniuk this is now published to PyPI! |
Description
This pull request contains minor code refactoring and fix for aggregated vote value is not updated till refresh.
Steps to Reproduce:
Expected Result:
Value is updated after click
