Skip to content
This repository was archived by the owner on Apr 14, 2026. It is now read-only.

fix: aggregated vote value is not updated till refresh#83

Merged
feanil merged 3 commits intoopenedx:masterfrom
raccoongang:romaniuk/fix/aggregated-vote-value-is-not–updated-till-refresh
Mar 10, 2025

Hidden character warning

The head ref may contain hidden characters: "romaniuk/fix/aggregated-vote-value-is-not\u2013updated-till-refresh"
Merged

fix: aggregated vote value is not updated till refresh#83
feanil merged 3 commits intoopenedx:masterfrom
raccoongang:romaniuk/fix/aggregated-vote-value-is-not–updated-till-refresh

Conversation

@ihor-romaniuk
Copy link
Copy Markdown
Contributor

Description

This pull request contains minor code refactoring and fix for aggregated vote value is not updated till refresh.

Steps to Reproduce:

  1. True is set for feedback - Show aggregate report to students option (in Studio)
  2. As user leave a vote (click for example on Good sign)
image
  1. Vote is updated but aggregated value (number in brackets) is not updated till refresh
image

Expected Result:

Value is updated after click
image

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 3, 2024
@openedx-webhooks
Copy link
Copy Markdown

openedx-webhooks commented May 3, 2024

Thanks for the pull request, @ihor-romaniuk!

This repository is currently maintained by @openedx/axim-engineering.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.76%. Comparing base (f8adb4a) to head (d2c004a).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
+ Coverage   92.37%   92.76%   +0.38%     
==========================================
  Files           5        5              
  Lines         223      221       -2     
==========================================
- Hits          206      205       -1     
+ Misses         17       16       -1     
Flag Coverage Δ
unittests 92.76% <100.00%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mphilbrick211
Copy link
Copy Markdown

@openedx/axim-engineering - is this something we can review / merge?

Copy link
Copy Markdown
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ihor-romaniuk this PR mixes styling changes with the actual changes you're trying to make, happy to take them both but I think they should be atleast separate commits so that it's easier to review the technical changes. Can you either split them or remove the style changes so that it's easier to review the logical change?

@mphilbrick211
Copy link
Copy Markdown

Hi @ihor-romaniuk! Just checking to see if this is still in-progress?

@mphilbrick211
Copy link
Copy Markdown

Friendly ping on this, @ihor-romaniuk!

@ihor-romaniuk ihor-romaniuk force-pushed the romaniuk/fix/aggregated-vote-value-is-not–updated-till-refresh branch from ee0bc9e to 40e5cad Compare March 4, 2025 11:39
@ihor-romaniuk ihor-romaniuk force-pushed the romaniuk/fix/aggregated-vote-value-is-not–updated-till-refresh branch from 40e5cad to f4a3ac7 Compare March 4, 2025 11:42
@ihor-romaniuk
Copy link
Copy Markdown
Contributor Author

@feanil Thanks for your comment.
I have separated main fix from other style refactoring. And it's ready for review

Copy link
Copy Markdown
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ihor-romaniuk change makes sense, and it's nice to reduce duplicate here for the scale html. Can you bump the version and then I can merge and make a new release.

@ihor-romaniuk
Copy link
Copy Markdown
Contributor Author

@feanil I updated version and it's ready for final review. Thanks.

@feanil feanil merged commit 3711dd0 into openedx:master Mar 10, 2025
@github-project-automation github-project-automation Bot moved this from In Eng Review to Done in Contributions Mar 10, 2025
@feanil
Copy link
Copy Markdown
Contributor

feanil commented Mar 10, 2025

Thanks @ihor-romaniuk this is now published to PyPI!

@ihor-romaniuk ihor-romaniuk deleted the romaniuk/fix/aggregated-vote-value-is-not–updated-till-refresh branch March 18, 2025 09:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants