Skip to content

Potential bug: incorrect comparison of double values #228

@dsuponitskiy

Description

@dsuponitskiy

src/pke/lib/scheme/ckksrns/ckksrns-utils.cpp:
uint32_t Degree(const std::vector& coefficients) {

uint32_t deg = 1;
for (int i = coefficients.size() - 1; i > 0; i--) {
if (coefficients[i] == 0) { <==== this comparison is almost never true when coefficients[i] holds zero
deg += 1;
}
else
break;
}
return coefficients.size() - deg;
}

Metadata

Metadata

Assignees

Labels

questionFurther information is requested

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions