Open
Conversation
| return Std.parseInt ("0x" + hex); | ||
| } | ||
|
|
||
| public static function parseRGBMatch(rgbMatch:EReg):Int |
Member
There was a problem hiding this comment.
What do you think about adding unit tests for these two new functions? (This one and parseHex)
Member
|
Looks pretty good. Your test images look awfully identical to each other :) |
Member
|
Please review @ibilon |
| // Support 3-character hex color shorthand | ||
| // e.g. #RGB -> #RRGGBB | ||
| if (hex.length == 3) { | ||
| hex = hex.substr(0,1) + hex.substr(0,1) + |
Member
There was a problem hiding this comment.
Better to make variables than calling substr twice.
Member
|
Besides the two details I commented, looks good. |
Member
|
Are you planning to fix this up and merge it @jcward ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per: https://www.w3.org/TR/SVG/types.html#ColorKeywords
Also moved color definitions and helpers into SVGColor class