Update OIDEndSessionRequest method signature to match nullability on type#753
Closed
mt00chikin wants to merge 2 commits intoopenid:masterfrom
Closed
Update OIDEndSessionRequest method signature to match nullability on type#753mt00chikin wants to merge 2 commits intoopenid:masterfrom
mt00chikin wants to merge 2 commits intoopenid:masterfrom
Conversation
Author
|
FYI, I have started the process of executing the agreements per the CONTRIBUTING guidelines |
radutx
approved these changes
May 2, 2023
radutx
approved these changes
May 25, 2023
|
Will this ever get merged? |
Author
|
Accomplished by #727 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the idTokenHint nullability annotation in OIDEndSessionRequest's initializers to match the property attributes on the type, so that Swift clients can use these methods more easily.
idTokenHintis declared as nullable on OIDEndSessionRequest and the implementation of this class already accounts for the possibility of the property being nil. However, the initializer methods omit the nullable annotation for the idTokenHint parameter.In Objective-C based clients this does not present a problem, since the compiler will allow nil to be passed in the init method. Swift clients, however, will fail to compile because the Swift interface treats idTokenHint as a
Stringand not aString?.This results in the following updated Swift interface:
This PR resolves the issue reported in #665