Skip to content

8378873: jpackage: remove macOS-specific code from jdk.jpackage.internal.ModuleInfo#29963

Open
alexeysemenyukoracle wants to merge 1 commit intoopenjdk:masterfrom
alexeysemenyukoracle:ModuleInfo-bugfix
Open

8378873: jpackage: remove macOS-specific code from jdk.jpackage.internal.ModuleInfo#29963
alexeysemenyukoracle wants to merge 1 commit intoopenjdk:masterfrom
alexeysemenyukoracle:ModuleInfo-bugfix

Conversation

@alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Feb 27, 2026

$subj. Move macOS-specific logic to MacFromOptions class.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8378873: jpackage: remove macOS-specific code from jdk.jpackage.internal.ModuleInfo (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29963/head:pull/29963
$ git checkout pull/29963

Update a local copy of the PR:
$ git checkout pull/29963
$ git pull https://git.openjdk.org/jdk.git pull/29963/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29963

View PR using the GUI difftool:
$ git pr show -t 29963

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29963.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 27, 2026

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 27, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

…re into LauncherStartupInfoBuilder#predefinedRuntimeImage()
@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Feb 27, 2026
@openjdk
Copy link

openjdk bot commented Feb 27, 2026

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@alexeysemenyukoracle alexeysemenyukoracle changed the title Pass the path to the directory with the standard Java runtime structu… 8378873: jpackage: remove macOS-specific code from jdk.jpackage.internal.ModuleInfo Feb 27, 2026
@alexeysemenyukoracle alexeysemenyukoracle marked this pull request as ready for review February 27, 2026 21:07
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 27, 2026
@mlbridge
Copy link

mlbridge bot commented Feb 27, 2026

Webrevs

@alexeysemenyukoracle
Copy link
Member Author

@sashamatveev PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant