8386911: Crypto benchmark regressions after JDK-8384353

[vpaprotsk]

With quadKeccak, it is possible to have 3 extra keccaks calls that are really noops.. teach SHA3Parallel.squeeze() how many operations it really should be doing.

While it is possible to match precisely the number of keccak calls required.. the previous implementation always called doubleKeccak, so collapsing the odd numbers to the closest even.

PS: make install-hsdis test TEST="micro:org.openjdk.bench.javax.crypto.full.SignatureBench.MLDSA" MICRO="JAVA_OPTIONS=-XX:+UnlockDiagnosticVMOptions -XX:-UseSHA3Intrinsics;FORK=1;ITER=3;TIME=10;WARMUP_ITER=7;WARMUP_TIME=10;OPTIONS=-prof perfasm -p algorithm=ML-DSA-65"

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8386911: Crypto benchmark regressions after JDK-8384353 (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31648/head:pull/31648
$ git checkout pull/31648

Update a local copy of the PR:
$ git checkout pull/31648
$ git pull https://git.openjdk.org/jdk.git pull/31648/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31648

View PR using the GUI difftool:
$ git pr show -t 31648

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31648.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vpaprotski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@vpaprotsk The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (14f8acfe)
• 00: Full (03ead216)

[ferakocz]

nr iterations is enough here.

[smemery]

I ran ML-KEM and ML-DSA benchmarks on a Macbook Pro M3 36GB Memory, see attached. Everything is improved with the set of changes except for ML-KEM-512 (encapsulation:-0.92%/decapsulation:-2.25%) and ML-DSA-44 (key generation:-1.03%).
8384353BenchmarksM3Pro.pdf

[smemery]

I ran ML-KEM and ML-DSA benchmarks on a Macbook Pro M3 36GB Memory, see attached. Everything is improved with the set of changes except for ML-KEM-512 (encapsulation:-0.92%/decapsulation:-2.25%) and ML-DSA-44 (key generation:-1.03%). 8384353BenchmarksM3Pro.pdf

Reran the specific benchmarks that showed regression on a quieter system (MacbookAir M3 8GB Memory) and averaged the results, which showed negligible differences of the afflicted benchmarks as follows: ML-KEM-512 (encapsulation:-0.38%/decapsulation:-0.21%) and ML-DSA-44 (key generation: -0.18%). In other words, the current fix resolves the regression in performance by either negligible differences or better performance, where the high observed +6.55% (ML-KEM-768, which would be one of the algorithms that would gain the most from this delta).