One big beautiful pull request#1113
Merged
AmyrAhmady merged 9 commits intoopenmultiplayer:masterfrom Sep 20, 2025
NexiusTailer:patch-1
Merged
One big beautiful pull request#1113AmyrAhmady merged 9 commits intoopenmultiplayer:masterfrom NexiusTailer:patch-1
AmyrAhmady merged 9 commits intoopenmultiplayer:masterfrom
NexiusTailer:patch-1
Conversation
by fixing the code order in PlayerVehicleSyncHandler, moving validation checks first
by fixing the code order in updateFromDriverSync, moving pure validations first
eliminating areas for abuse, like in SA-MP server
but also add a check for train carriages, since they always consider unstreamed
RonaldoBueno16
approved these changes
Aug 26, 2025
Woet
approved these changes
Sep 13, 2025
DEntis-T
approved these changes
Sep 13, 2025
midosvt
approved these changes
Sep 13, 2025
Member
midosvt
left a comment
There was a problem hiding this comment.
Wow, this PR is like taking a messy plate of spaghetti code, untangling the noodles, and putting them back in order before anyone chokes on them. 🍝
The fixes make total sense -- moving validation checks before side effects is the programming equivalent of washing your hands before eating, not after. Also, I appreciate the cheater smackdown -- no more ‘free teleport to anywhere’ passenger perks.
Overall: looking really good. Clean, logical, and it closes some pretty nasty loopholes. Thanks for making vehicle sync less of a clown car. 🚗🤡
Sreyas-Sreelal
approved these changes
Sep 14, 2025
equinnoxy
approved these changes
Sep 14, 2025
KW46
approved these changes
Sep 20, 2025
AmyrAhmady
approved these changes
Sep 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.