Skip to content

Remove preconnect packet handler#820

Merged
AmyrAhmady merged 2 commits intomasterfrom
amir/remove-preconnect-packets
Dec 31, 2023
Merged

Remove preconnect packet handler#820
AmyrAhmady merged 2 commits intomasterfrom
amir/remove-preconnect-packets

Conversation

@AmyrAhmady
Copy link
Copy Markdown
Member

No description provided.

Basically because it's not "safe" but it is already discussed
So I'm not going to publicly talk about it here.
@AmyrAhmady AmyrAhmady requested a review from Hual December 30, 2023 18:43
@Zorono
Copy link
Copy Markdown
Contributor

Zorono commented Dec 31, 2023

excuse me
please can you explain this PR ??

@AmyrAhmady
Copy link
Copy Markdown
Member Author

server can receive packets before player instance being initialized, so open.mp was keeping "pre-connect" packets in a map to process them later when player is fully initialized.
This is a very very very rare case that the only time I know it happens is when a user uses SAMP Android. It sends a client config data packet before connect packet to servers, so I was aiming to fix that by letting server process that config packet after successfully connecting and initializing the player instance, but this way of doing it caused more issues than fixing some issues that shouldn't have even existed in the first place.

@AmyrAhmady AmyrAhmady merged commit 384b8e3 into master Dec 31, 2023
@AmyrAhmady AmyrAhmady deleted the amir/remove-preconnect-packets branch December 31, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants