Conversation
Increased default plot height and allowed for 'full screen' plot viewing when only 1 is selected.
There was a problem hiding this comment.
Pull request overview
Updates the mod_study_forms time-series plot sizing to make plots taller by default, with a special-case height when only a single item/plot is selected.
Changes:
- Introduces
plot_cnt/plot_heightcalculation to determine Plotly widget height based on number of selected items. - Replaces the previous inline height formula with the new computed
plot_height.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
LDSamson
left a comment
LDSamson
left a comment
There was a problem hiding this comment.
Hi, I am not opposed to such a change. Can you show a few screenshots or a small video of how it looks like now?
Are the figures looking nice in small and big screen resolutions? And if there are many plots or just a few plots, is the figure height (fairly) consistent?
Also, I noticed that apart from adding tall one-facet plot, you also changed the base height. Did you like the newly proposed base height more? (200 instead of 175).
|
Pushed a commit to move the Also, here is a view on my laptop screen (a 14" screen; Screen rez below) with 100% zoom in the browser. I'd think this is representative of a "small screen". Old
New
The most dramatic change by far is when viewing a single plot. Really nice 👍🏼 Main difference when viewing all plots is that users went from see about 3 plots to about 2.333. I'm not fond of having to scroll down a bit in "full screen" mode, so we could tweak it down a bit, but it looks great on a big monitor. |
Co-authored-by: Leon Samson <42182207+LDSamson@users.noreply.github.com>
…ight into ac-taller-plots
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Hi @LDSamson, we implemented this internally per request of our users and thought it might be useful for the open-source community. Pretty simple change. Thoughts?
What's changed?
Increased default plot height and allowed for 'full screen' plot viewing when only 1 is selected.