This repository was archived by the owner on Aug 3, 2023. It is now read-only.
modified event transmission method to gRPC request stream#36
Merged
stormcat24 merged 1 commit intomasterfrom May 29, 2017
Merged
modified event transmission method to gRPC request stream#36stormcat24 merged 1 commit intomasterfrom
stormcat24 merged 1 commit intomasterfrom
Conversation
stormcat24
commented
May 29, 2017
| return c.payloadChan | ||
| } | ||
|
|
||
| func (c *Client) SetEvents(events []string) { |
Contributor
Author
There was a problem hiding this comment.
[golint]
- [golint] exported method Client.SetEvents should have comment or be unexported
stormcat24
commented
May 29, 2017
| close(client.payloadChan) | ||
| } | ||
|
|
||
| func (cm *ClientManager) DeleteEvents(client *Client) { |
Contributor
Author
There was a problem hiding this comment.
[golint]
- [golint] exported method ClientManager.DeleteEvents should have comment or be unexported
stormcat24
commented
May 29, 2017
| zap.Array("request-events", zapcore.ArrayMarshalerFunc(func(enc zapcore.ArrayEncoder) error { | ||
| for _, e := range request.Events { | ||
| enc.AppendString(e.Type) | ||
| func (ss *StreamServer) Events(es proto.StreamService_EventsServer) error { |
Contributor
Author
There was a problem hiding this comment.
[golint]
- [golint] exported method StreamServer.Events should have comment or be unexported
stormcat24
commented
May 29, 2017
| if grpc.Code(err) != codes.Canceled { | ||
| ss.errChan <- errors.Wrap(err, "Recv error") | ||
| return | ||
| } else { |
Contributor
Author
There was a problem hiding this comment.
[golint]
- [golint] if block ends with a return statement, so drop this else and outdent its block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.