feat(chart/opensearch): add ability for serviceMonitor basicauth #594

eyenx · 2024-09-10T15:09:09Z

Description

Right now there is non possibility to set a basicAuth configuration for the serviceMonitor. This PR adds it

Check List

Commits are signed per the DCO using --signoff

For any changes to files within Helm chart directories:

Helm chart version bumped
Helm chart CHANGELOG.md updated to reflect change

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

peterzhuamazon · 2024-09-17T17:01:39Z

Note: We are in the review of an older PR now so will come back to this a little later.

eyenx · 2024-10-18T06:00:07Z

@peterzhuamazon any update here? Thanks!

eyenx · 2024-11-05T08:47:33Z

@peterzhuamazon any update here?

peterzhuamazon

Seems fine for me on this change.

cc: @prudhvigodithi @TheAlgo to take a look as well.

Thanks.

prudhvigodithi · 2024-11-06T21:08:58Z

charts/opensearch/values.yaml

+  #   password:
+  #     secretName: credentials
+  #     secretKey: password
+  basicAuth: {} 


Thanks @eyenx can you please some details in the README ? also can basicAuth have one secret with username and password ?

I will take a look at it tomorrow

I now added a existingSecret functionality and a way to deliver the username & pw over the helm charts values

peterzhuamazon · 2024-11-15T20:21:43Z

Hi @TheAlgo @prudhvigodithi please take another pass before I give an approval.

Thanks.

peterzhuamazon · 2024-11-25T22:56:21Z

Pinging @prudhvigodithi @TheAlgo again to co-review.

Thanks!

eyenx · 2024-12-13T15:06:21Z

@prudhvigodithi @TheAlgo @peterzhuamazon Another attempt at getting this merged!

Please review! Thank you!

eyenx · 2024-12-13T15:17:14Z

I would also be very happy to backport this to version 1.x

peterzhuamazon · 2024-12-13T16:35:36Z

Adding @TheAlgo @prudhvigodithi @DandyDeveloper @gaiksaya to take a look.

Thanks!

muhammeddanish · 2024-12-17T07:50:53Z

Hi Team,

When we can expect a 1.3.x version of this changes (#593 as well)?

Thanks,
Danish

eyenx · 2024-12-18T05:36:08Z

As soon as this gets merged I will backport it.

charts/opensearch/Chart.yaml

eyenx · 2024-12-18T05:39:25Z

Will rebase today

Signed-off-by: Toni Tauro <[email protected]>

eyenx · 2024-12-18T07:26:20Z

Ready for Review @TheAlgo @DandyDeveloper @gaiksaya @prudhvigodithi

Signed-off-by: Toni Tauro <[email protected]>

muhammeddanish · 2024-12-18T12:14:29Z

As soon as this gets merged I will backport it.

Thanks much @eyenx !!

eyenx · 2024-12-19T07:47:00Z

As soon as this gets merged I will backport it.

Thanks much @eyenx !!

backport for #593 is here #636

prudhvigodithi · 2024-12-23T14:07:09Z

charts/opensearch/README.md

 | `serviceMonitor.path` | Path where metrics are exposed. Applicable only if `serviceMonitor.enabled` is set to `true`. | `/_prometheus/metrics` |
 | `serviceMonitor.interval` | Interval at which metrics should be scraped by Prometheus. Applicable only if `serviceMonitor.enabled` is set to `true`. | `10s` |
+| `serviceMonitor.basicAuth.enabled`        | Wheter or not the serviceMonitor should use basic auth                                                                                                                                                                                                                                                                                                                                                                                                                                                                             | `false`                                                                                                         |
+| `serviceMonitor.basicAuth.existingSecret` | When using basicAuth for the serviceMonitory, use an existing secret                                                                                                                                                                                                                                                                                                                                                                                                                                                               | `""`                                                                                                            |


Is serviceMonitory typo?

Hey @eyenx please take a look, we can get this merged.
Thanks

Yes it's a typo :)

@prudhvigodithi fixed.

prudhvigodithi · 2024-12-23T14:08:02Z

Thanks @eyenx we can get this merged.

Signed-off-by: Toni Tauro <[email protected]>

peterzhuamazon · 2025-01-01T17:49:19Z

Will check if it is ready to merge tomorrow.

peterzhuamazon · 2025-01-02T19:52:20Z

Thanks @eyenx can you backport this to 1.x?

eyenx · 2025-01-02T19:55:48Z

Sure!

eyenx · 2025-01-02T20:25:06Z

Thanks @eyenx can you backport this to 1.x?

Backport #637

…nsearch-project#594) * feat(chart/opensearch): add ability for serviceMonitor basicauth Signed-off-by: Toni Tauro <[email protected]> * fix(Chart.yaml): bump versionn Signed-off-by: Toni Tauro <[email protected]> * feat(basicAuth): change to existingSecret format Signed-off-by: Toni Tauro <[email protected]> * fix(README): just add my notes Signed-off-by: Toni Tauro <[email protected]> * fix(README): correct file Signed-off-by: Toni Tauro <[email protected]> * fix(Chart): bump version Signed-off-by: Toni Tauro <[email protected]> * fix(README): typo Signed-off-by: Toni Tauro <[email protected]> --------- Signed-off-by: Toni Tauro <[email protected]> Signed-off-by: ainthapanya-sqc <[email protected]>

eyenx requested review from DandyDeveloper, TheAlgo, gaiksaya, peterzhuamazon and prudhvigodithi as code owners September 10, 2024 15:09

github-actions bot added the first-time-contributor label Sep 10, 2024

peterzhuamazon reviewed Nov 6, 2024

View reviewed changes

prudhvigodithi reviewed Nov 6, 2024

View reviewed changes

eyenx mentioned this pull request Nov 15, 2024

[BUG][opensearch] cant connect to metrics endpoint #590

Open

eyenx force-pushed the feat/serviceMonitor-with-basic-auth branch from c4b5ba0 to f3a06ee Compare November 15, 2024 07:11

eyenx force-pushed the feat/serviceMonitor-with-basic-auth branch from f3a06ee to 9d239a8 Compare December 13, 2024 15:05

eyenx mentioned this pull request Dec 13, 2024

fix(chart/opensearch): metricsPort and plugins usage info in values.yaml #593

Merged

3 tasks

eyenx commented Dec 18, 2024

View reviewed changes

charts/opensearch/Chart.yaml Outdated Show resolved Hide resolved

eyenx added 3 commits December 18, 2024 08:25

feat(chart/opensearch): add ability for serviceMonitor basicauth

a3102c7

Signed-off-by: Toni Tauro <[email protected]>

fix(Chart.yaml): bump versionn

3e5d345

Signed-off-by: Toni Tauro <[email protected]>

feat(basicAuth): change to existingSecret format

5dd0ace

Signed-off-by: Toni Tauro <[email protected]>

eyenx force-pushed the feat/serviceMonitor-with-basic-auth branch from 9d239a8 to 5dd0ace Compare December 18, 2024 07:26

fix(README): just add my notes

ab30eca

Signed-off-by: Toni Tauro <[email protected]>

eyenx added 2 commits December 18, 2024 08:31

fix(README): correct file

df583dd

Signed-off-by: Toni Tauro <[email protected]>

fix(Chart): bump version

69e35b4

Signed-off-by: Toni Tauro <[email protected]>

eyenx requested review from peterzhuamazon and prudhvigodithi December 19, 2024 09:58

prudhvigodithi reviewed Dec 23, 2024

View reviewed changes

prudhvigodithi approved these changes Dec 23, 2024

View reviewed changes

fix(README): typo

d6d0261

Signed-off-by: Toni Tauro <[email protected]>

peterzhuamazon mentioned this pull request Jan 1, 2025

add plugins.removeList to allow remove plugins #526

Merged

3 tasks

peterzhuamazon merged commit 452261e into opensearch-project:main Jan 2, 2025
8 checks passed

eyenx mentioned this pull request Jan 2, 2025

feat(backport/opensearch): update chart to version 1.34.0 with serviceMon BasicAuth #637

Merged

3 tasks

feat(chart/opensearch): add ability for serviceMonitor basicauth #594

feat(chart/opensearch): add ability for serviceMonitor basicauth #594

Uh oh!

Conversation

eyenx commented Sep 10, 2024

Description

Check List

Uh oh!

peterzhuamazon commented Sep 17, 2024

Uh oh!

eyenx commented Oct 18, 2024

Uh oh!

eyenx commented Nov 5, 2024

Uh oh!

peterzhuamazon left a comment

Choose a reason for hiding this comment

Uh oh!

prudhvigodithi Nov 6, 2024

Choose a reason for hiding this comment

Uh oh!

eyenx Nov 14, 2024

Choose a reason for hiding this comment

Uh oh!

eyenx Nov 15, 2024

Choose a reason for hiding this comment

Uh oh!

peterzhuamazon commented Nov 15, 2024

Uh oh!

peterzhuamazon commented Nov 25, 2024

Uh oh!

eyenx commented Dec 13, 2024

Uh oh!

eyenx commented Dec 13, 2024

Uh oh!

peterzhuamazon commented Dec 13, 2024

Uh oh!

muhammeddanish commented Dec 17, 2024

Uh oh!

eyenx commented Dec 18, 2024

Uh oh!

Uh oh!

eyenx commented Dec 18, 2024

Uh oh!

eyenx commented Dec 18, 2024

Uh oh!

muhammeddanish commented Dec 18, 2024

Uh oh!

eyenx commented Dec 19, 2024

Uh oh!

prudhvigodithi Dec 23, 2024

Choose a reason for hiding this comment

Uh oh!

prudhvigodithi Dec 24, 2024

Choose a reason for hiding this comment

Uh oh!

eyenx Dec 31, 2024

Choose a reason for hiding this comment

Uh oh!

eyenx Dec 31, 2024

Choose a reason for hiding this comment

Uh oh!

prudhvigodithi commented Dec 23, 2024

Uh oh!

peterzhuamazon commented Jan 1, 2025

Uh oh!

Uh oh!

peterzhuamazon commented Jan 2, 2025

Uh oh!

eyenx commented Jan 2, 2025

Uh oh!

eyenx commented Jan 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

eyenx commented Jan 2, 2025 •

edited

Loading