Modify namespace from opendistro to opensearch#12
Merged
Conversation
Signed-off-by: Sruti Parthiban <partsrut@amazon.com>
sruti1312
force-pushed
the
partsrut-namespace-change
branch
from
c0b961a to
060141b
Compare
hxiao608
reviewed
May 18, 2021
| try { | ||
| final Response response = client().performRequest(postRequest); | ||
| Assert.assertEquals(HttpStatus.SC_OK, response.getStatusLine().getStatusCode()); | ||
| assertEquals(HttpStatus.SC_OK, response.getStatusLine().getStatusCode()); |
Contributor
There was a problem hiding this comment.
assertEquals seems not imported
hxiao608
reviewed
May 18, 2021
| public void testGetNodeStatsShardsPerCollection() { | ||
| assertEquals( | ||
| DEFAULT_NUM_OF_SHARDS_PER_COLLECTION, controller.getNodeStatsShardsPerCollection()); | ||
| Assert.assertEquals( |
Contributor
There was a problem hiding this comment.
Should we keep an uniform format here in the package-wise? (either use Assert.assertEquals or assertEquals)
Contributor
Author
There was a problem hiding this comment.
Right. Assert.assertEquals is used almost everywhere. In case of ConfigOverridesIT.java, it extends that from the PerformanceAnalyzerIntegTestBase. Spotless takes care of these changes automatically.
hxiao608
suggested changes
May 18, 2021
Contributor
There was a problem hiding this comment.
There are a few doc links that can also be changed. For example, in Readme.md, the api reference. https://docs-beta.opensearch.org/
Signed-off-by: Sruti Parthiban <partsrut@amazon.com>
hxiao608
approved these changes
May 18, 2021
jotok
approved these changes
May 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sruti Parthiban partsrut@amazon.com
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you are proposing
Modify namespace from opendistro to opensearch
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.