Adds setting to enable/disable Thread Contention Monitoring#171
Merged
sruti1312 merged 2 commits intoopensearch-project:mainfrom Apr 11, 2022
Merged
Adds setting to enable/disable Thread Contention Monitoring#171sruti1312 merged 2 commits intoopensearch-project:mainfrom
sruti1312 merged 2 commits intoopensearch-project:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #171 +/- ##
============================================
+ Coverage 71.61% 71.77% +0.16%
- Complexity 355 367 +12
============================================
Files 44 44
Lines 2459 2519 +60
Branches 160 169 +9
============================================
+ Hits 1761 1808 +47
- Misses 591 598 +7
- Partials 107 113 +6
Continue to review full report at Codecov.
|
sruti1312
suggested changes
Apr 6, 2022
| try { | ||
| threadContentionMonitoringEnabledFromConf = readBooleanFromFile(filePath); | ||
| } catch (NoSuchFileException e) { | ||
| LOG.debug("Error reading Performance Analyzer state from Conf file", e); |
Contributor
There was a problem hiding this comment.
Error reading thread contention monitoring state?
Contributor
There was a problem hiding this comment.
@eirsep nit: I think this change was missed in the revision.
| if (shouldEnable | ||
| && !performanceAnalyzerController.isPerformanceAnalyzerEnabled()) { | ||
| return getChannelConsumerWithError( | ||
| "Error: PA not enabled. Enable PA before turning Batch Metrics on"); |
Contributor
There was a problem hiding this comment.
nit: "Enable PA before turning thread contention monitoring on"
| @Test | ||
| public void disabledClusterStateTest() { | ||
| setControllerValues(DISABLED_STATE, DISABLED_STATE, DISABLED_STATE, DISABLED_STATE); | ||
| setControllerValues(DISABLED_STATE, DISABLED_STATE, DISABLED_STATE, DISABLED_STATE,DISABLED_STATE ); |
Contributor
There was a problem hiding this comment.
nit: space before DISABLED_STATE.
I see a couple of formatting issues. Can we run ./gradlew spotlessApply
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
sruti1312
approved these changes
Apr 11, 2022
sgup432
approved these changes
Apr 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Surya Sashank Nistala snistala@amazon.com
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you are proposing
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.