Add --progress flag to show real-time test execution#63
Add --progress flag to show real-time test execution#63camilamacedo86 wants to merge 1 commit intoopenshift-eng:mainfrom
Conversation
This commit adds support for Ginkgo's progress reporting feature by exposing a --progress flag in both run-suite and run-test commands. Changes: - Added --progress flag to run-suite command - Added --progress flag to run-test command - Modified Ginkgo configuration to enable ShowNodeEvents when progress is requested - Progress can also be enabled via OTE_PROGRESS=true environment variable When --progress is enabled, users will see STEP output in real-time as tests execute, rather than only seeing output after tests complete. This significantly improves the local development experience for long-running tests (e.g., operator installation, upgrade tests). Example usage: ./bin/test-binary run-suite my/suite --progress ./bin/test-binary run-test -n "test name" --progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| concurrencyFlags *flags.ConcurrencyFlags | ||
| junitPath string | ||
| htmlPath string | ||
| progress bool |
There was a problem hiding this comment.
nit: maybe isShowProgress or showProgress?
| ) | ||
|
|
||
| func configureGinkgo() (*types.SuiteConfig, *types.ReporterConfig, error) { | ||
| return configureGinkgoWithProgress(false) |
There was a problem hiding this comment.
would it be better to do something like:
| return configureGinkgoWithProgress(false) | |
| return configureGinkgoWithProgress(os.Getenv("OTE_PROGRESS") == "true") |
we seem to be setting the OTE_PROGRESS in runsuite.go
as it is we call it with false but the that intent gets overridden by the env var.
|
|
||
| // Enable progress reporting if requested via --progress flag or OTE_PROGRESS env var | ||
| // This shows STEP output as tests run, not just when they complete | ||
| if showProgress || os.Getenv("OTE_PROGRESS") == "true" { |
There was a problem hiding this comment.
let's remove this hidden condition and move the env var check to the callers or configureGinkgoWithProgress
| if showProgress || os.Getenv("OTE_PROGRESS") == "true" { | |
| if showProgress { |
2 participants
This commit adds support for Ginkgo's progress reporting feature by exposing a --progress flag in both run-suite and run-test commands.
Changes:
When --progress is enabled, users will see STEP output in real-time as tests execute, rather than only seeing output after tests complete.
This significantly improves the local development experience for long-running tests (e.g., operator installation, upgrade tests).
Example usage:
./bin/test-binary run-suite my/suite --progress
./bin/test-binary run-test -n "test name" --progress
Closes: https://github.com/openshift-eng/openshift-tests-extension/issues
Generated-by: Claude