-
Notifications
You must be signed in to change notification settings - Fork 668
ODC-7756, CONSOLE-4464: Bump PF6 to latest prereleases #14783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ODC-7756, CONSOLE-4464: Bump PF6 to latest prereleases #14783
Conversation
|
@logonoff: This pull request references ODC-7756 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
adding labels for PF6 follow on ticket /label px-approved code review: QE review: |
vikram-raj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
dcd93e1 to
791cdff
Compare
|
@logonoff: This pull request references CONSOLE-4464 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@logonoff: This pull request references ODC-7756 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. This pull request references CONSOLE-4464 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@logonoff: This pull request references ODC-7756 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. This pull request references CONSOLE-4464 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Mind also bumping console/dynamic-demo-plugin/package.json Lines 20 to 22 in f5d923b
|
|
@logonoff: This pull request references ODC-7756 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. This pull request references CONSOLE-4464 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
3ccd6dc to
34bd8a9
Compare
Bumped! |
|
/lgtm |
|
/hold PR now includes commits from #14880 (to use the |
b6f0be6 to
a5229d0
Compare
|
/retest |
d8c65bf to
cd89ef1
Compare
a075425 to
cd89ef1
Compare
|
/label acknowledge-critical-fixes-only |
|
/unhold |
ODC-7756: Fix **Add to project** option in topology page also bump typescript in the demo plugin due to `@types/lodash` incompatibility `marked` is a new peer dependency for quickstarts
cd89ef1 to
2227141
Compare
|
@rhamilto, mind retagging? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff, rhamilto, vikram-raj The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@logonoff: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-console |

fixes https://issues.redhat.com/browse/ODC-7756
bumps console to the latest available PatternFly prereleases, so we can start testing them
note that
markedis a new peer dependency for quickstarts