Skip to content

Conversation

@logonoff
Copy link
Member

@logonoff logonoff commented Feb 19, 2025

fixes https://issues.redhat.com/browse/ODC-7756

bumps console to the latest available PatternFly prereleases, so we can start testing them

note that marked is a new peer dependency for quickstarts

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 19, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 19, 2025

@logonoff: This pull request references ODC-7756 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

Details

In response to this:

fixes https://issues.redhat.com/browse/ODC-7756

after:
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff changed the title ODC-7756: Fix **Add to project** option in topology page ODC-7756: Fix Add to project option in topology page Feb 19, 2025
@openshift-ci openshift-ci bot requested review from kyoto and spadgett February 19, 2025 21:27
@logonoff
Copy link
Member Author

adding labels for PF6 follow on ticket

/label px-approved
/label docs-approved

code review:
/assign @vikram-raj

QE review:
/assign @sanketpathak

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Feb 19, 2025
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 25, 2025
@logonoff logonoff force-pushed the ODC-7756-topology branch from dcd93e1 to 791cdff Compare March 5, 2025 20:18
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2025
@logonoff logonoff changed the title ODC-7756: Fix Add to project option in topology page CONSOLE-4464: Bump PF6 to latest prereleases Mar 5, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 5, 2025

@logonoff: This pull request references CONSOLE-4464 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

fixes https://issues.redhat.com/browse/ODC-7756

after:
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff changed the title CONSOLE-4464: Bump PF6 to latest prereleases ODC-7756, CONSOLE-4464: Bump PF6 to latest prereleases Mar 5, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 5, 2025

@logonoff: This pull request references ODC-7756 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

This pull request references CONSOLE-4464 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

fixes https://issues.redhat.com/browse/ODC-7756

after:
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff
Copy link
Member Author

logonoff commented Mar 5, 2025

also assigning admin console team as I expanded the PR scope

code review:
/assign @rhamilto

QE review:
/assign @yapei

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 5, 2025

@logonoff: This pull request references ODC-7756 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

This pull request references CONSOLE-4464 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

fixes https://issues.redhat.com/browse/ODC-7756

bumps console to the latest available PatternFly prereleases, so we can start testing them

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto
Copy link
Member

rhamilto commented Mar 5, 2025

Mind also bumping

"@patternfly/react-core": "^6.2.0-prerelease.15",
"@patternfly/react-icons": "^6.2.0-prerelease.2",
"@patternfly/react-table": "^6.2.0-prerelease.16",
?

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 5, 2025

@logonoff: This pull request references ODC-7756 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

This pull request references CONSOLE-4464 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

fixes https://issues.redhat.com/browse/ODC-7756

bumps console to the latest available PatternFly prereleases, so we can start testing them

note that marked is a new peer dependency for quickstarts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff force-pushed the ODC-7756-topology branch from 3ccd6dc to 34bd8a9 Compare March 5, 2025 20:26
@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2025
@logonoff
Copy link
Member Author

logonoff commented Mar 5, 2025

Mind also bumping

"@patternfly/react-core": "^6.2.0-prerelease.15",
"@patternfly/react-icons": "^6.2.0-prerelease.2",
"@patternfly/react-table": "^6.2.0-prerelease.16",

?

Bumped!

@rhamilto
Copy link
Member

rhamilto commented Mar 5, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2025
@openshift-ci openshift-ci bot added component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk labels Mar 25, 2025
@logonoff
Copy link
Member Author

/hold

PR now includes commits from #14880 (to use the Element.closest jest polyfill), which should merge first

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2025
@logonoff logonoff force-pushed the ODC-7756-topology branch 2 times, most recently from b6f0be6 to a5229d0 Compare March 25, 2025 20:50
@rhamilto
Copy link
Member

/retest

@logonoff logonoff force-pushed the ODC-7756-topology branch 2 times, most recently from d8c65bf to cd89ef1 Compare March 26, 2025 15:15
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2025
@logonoff logonoff force-pushed the ODC-7756-topology branch from a075425 to cd89ef1 Compare March 26, 2025 18:19
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2025
@logonoff
Copy link
Member Author

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Mar 27, 2025
@logonoff
Copy link
Member Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2025
ODC-7756: Fix **Add to project** option in topology page

also bump typescript in the demo plugin due to `@types/lodash` incompatibility

`marked` is a new peer dependency for quickstarts
@logonoff logonoff force-pushed the ODC-7756-topology branch from cd89ef1 to 2227141 Compare March 28, 2025 22:09
@logonoff
Copy link
Member Author

@rhamilto, mind retagging?

@rhamilto
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, rhamilto, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d3ed00e and 2 for PR HEAD 2227141 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 29, 2025

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 3bc8cb9 into openshift:main Mar 29, 2025
8 checks passed
@logonoff logonoff deleted the ODC-7756-topology branch March 29, 2025 17:30
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console
This PR has been included in build openshift-enterprise-console-container-v4.20.0-202503291941.p0.g3bc8cb9.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/git-service Related to git-service component/olm Related to OLM component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants