Skip to content

MCO-1648: MCO-1649: Add machineconfignodes and pinnedimagesets to must-gather#487

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
isabella-janssen:addMCNToMustGather
Apr 28, 2025
Merged

MCO-1648: MCO-1649: Add machineconfignodes and pinnedimagesets to must-gather#487
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
isabella-janssen:addMCNToMustGather

Conversation

@isabella-janssen
Copy link
Copy Markdown
Member

@isabella-janssen isabella-janssen commented Apr 28, 2025 •
edited
Loading

This adds the MachineConfigNodes and PinnedImageSets resources to must gathers.

To test:

  1. Launch a 4.19 cluster with tech preview enabled.
launch 4.19.0-0.ci-2025-04-28-053740 aws,techpreview
  1. Apply a PIS.
Example PIS 
apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
  name: test-pinned
  labels:
    machineconfiguration.openshift.io/role: "worker"
spec:
  pinnedImages:
   - name: quay.io/openshift-release-dev/ocp-release@sha256:513cf1028aa1a021fa73d0601427a0fbcf6d212b88aaf9d76d4e4841a061e44e
   - name: quay.io/openshift-release-dev/ocp-release@sha256:61eae2d261e54d1b8a0e05f6b5326228b00468364563745eed88460af04f909b

$ oc apply -f <pis-file>
  1. Create the must-gather from the updated gather_ppc script.
./collection-scripts/gather_ppc
  1. See the resources in the created must-gather.
must-gather
-- cluster-scoped-resources
---- machineconfiguration.openshift.io
...
------ machineconfignodes
-------- ip-10-0-0-9.ec2.internal.yaml
-------- ip-10-0-58-49.ec2.internal.yaml
-------- ip-10-0-7-211.ec2.internal.yaml
-------- ip-10-0-43-205.ec2.internal.yaml
-------- ip-10-0-66-94.ec2.internal.yaml
-------- ip-10-0-78-97.ec2.internal.yaml
...
------ pinnedimagesets
-------- test-pinned.yaml

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 28, 2025

@isabella-janssen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn ac60dd2 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@isabella-janssen isabella-janssen changed the title add machineconfignodes and pinnedimages to mustgather MCO-1648: MCO-1649: Add machineconfignodes and pinnedimages to must-gather Apr 28, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 28, 2025 •
edited by openshift-ci Bot
Loading

@isabella-janssen: This pull request references MCO-1648 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 28, 2025
@isabella-janssen isabella-janssen changed the title MCO-1648: MCO-1649: Add machineconfignodes and pinnedimages to must-gather MCO-1648: MCO-1649: Add machineconfignodes and pinnedimagesets to must-gather Apr 28, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 28, 2025 •
edited by openshift-ci Bot
Loading

@isabella-janssen: This pull request references MCO-1648 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

This adds the MachineConfigNodes and PinnedImageSets resources to must gathers.

To test:

  1. Launch a 4.19 cluster with tech preview enabled.
launch 4.19.0-0.ci-2025-04-28-053740 aws,techpreview
  1. Apply a PIS.
Example PIS 
apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
 name: test-pinned
 labels:
   machineconfiguration.openshift.io/role: "worker"
spec:
 pinnedImages:
  - name: quay.io/openshift-release-dev/ocp-release@sha256:513cf1028aa1a021fa73d0601427a0fbcf6d212b88aaf9d76d4e4841a061e44e
  - name: quay.io/openshift-release-dev/ocp-release@sha256:61eae2d261e54d1b8a0e05f6b5326228b00468364563745eed88460af04f909b

$ oc apply -f <pis-file>
  1. Create the must-gather from the updated gather_ppc script.
./collection-scripts/gather_ppc
  1. See the resources in the created must-gather.
must-gather
-- cluster-scoped-resources
---- machineconfiguration.openshift.io
...
------ machineconfignodes
-------- ip-10-0-0-9.ec2.internal.yaml
-------- ip-10-0-58-49.ec2.internal.yaml
-------- ip-10-0-7-211.ec2.internal.yaml
-------- ip-10-0-43-205.ec2.internal.yaml
-------- ip-10-0-66-94.ec2.internal.yaml
-------- ip-10-0-78-97.ec2.internal.yaml
...
------ pinnedimagesets
-------- test-pinned.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@djoshy
Copy link
Copy Markdown
Contributor

djoshy commented Apr 28, 2025

Sane from MCO POV

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 28, 2025 •
edited by openshift-ci Bot
Loading

@isabella-janssen: This pull request references MCO-1648 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

This adds the MachineConfigNodes and PinnedImageSets resources to must gathers.

To test:

  1. Launch a 4.19 cluster with tech preview enabled.
launch 4.19.0-0.ci-2025-04-28-053740 aws,techpreview
  1. Apply a PIS.
Example PIS 
apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
 name: test-pinned
 labels:
   machineconfiguration.openshift.io/role: "worker"
spec:
 pinnedImages:
  - name: quay.io/openshift-release-dev/ocp-release@sha256:513cf1028aa1a021fa73d0601427a0fbcf6d212b88aaf9d76d4e4841a061e44e
  - name: quay.io/openshift-release-dev/ocp-release@sha256:61eae2d261e54d1b8a0e05f6b5326228b00468364563745eed88460af04f909b

$ oc apply -f <pis-file>
  1. Create the must-gather from the updated gather_ppc script.
./collection-scripts/gather_ppc
  1. See the resources in the created must-gather.
|  must-gather
|  |  cluster-scoped-resources
|  |  |  machineconfiguration.openshift.io
...
|  |  |  |  machineconfignodes
-------- ip-10-0-0-9.ec2.internal.yaml
-------- ip-10-0-58-49.ec2.internal.yaml
-------- ip-10-0-7-211.ec2.internal.yaml
-------- ip-10-0-43-205.ec2.internal.yaml
-------- ip-10-0-66-94.ec2.internal.yaml
-------- ip-10-0-78-97.ec2.internal.yaml
...
------ pinnedimagesets
-------- test-pinned.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 28, 2025 •
edited by openshift-ci Bot
Loading

@isabella-janssen: This pull request references MCO-1648 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

This adds the MachineConfigNodes and PinnedImageSets resources to must gathers.

To test:

  1. Launch a 4.19 cluster with tech preview enabled.
launch 4.19.0-0.ci-2025-04-28-053740 aws,techpreview
  1. Apply a PIS.
Example PIS 
apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
 name: test-pinned
 labels:
   machineconfiguration.openshift.io/role: "worker"
spec:
 pinnedImages:
  - name: quay.io/openshift-release-dev/ocp-release@sha256:513cf1028aa1a021fa73d0601427a0fbcf6d212b88aaf9d76d4e4841a061e44e
  - name: quay.io/openshift-release-dev/ocp-release@sha256:61eae2d261e54d1b8a0e05f6b5326228b00468364563745eed88460af04f909b

$ oc apply -f <pis-file>
  1. Create the must-gather from the updated gather_ppc script.
./collection-scripts/gather_ppc
  1. See the resources in the created must-gather.
|   must-gather
|   |   cluster-scoped-resources
|   |   |   machineconfiguration.openshift.io
...
|   |   |   |   machineconfignodes
-------- ip-10-0-0-9.ec2.internal.yaml
-------- ip-10-0-58-49.ec2.internal.yaml
-------- ip-10-0-7-211.ec2.internal.yaml
-------- ip-10-0-43-205.ec2.internal.yaml
-------- ip-10-0-66-94.ec2.internal.yaml
-------- ip-10-0-78-97.ec2.internal.yaml
...
------ pinnedimagesets
-------- test-pinned.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 28, 2025 •
edited by openshift-ci Bot
Loading

@isabella-janssen: This pull request references MCO-1648 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

This adds the MachineConfigNodes and PinnedImageSets resources to must gathers.

To test:

  1. Launch a 4.19 cluster with tech preview enabled.
launch 4.19.0-0.ci-2025-04-28-053740 aws,techpreview
  1. Apply a PIS.
Example PIS 
apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
 name: test-pinned
 labels:
   machineconfiguration.openshift.io/role: "worker"
spec:
 pinnedImages:
  - name: quay.io/openshift-release-dev/ocp-release@sha256:513cf1028aa1a021fa73d0601427a0fbcf6d212b88aaf9d76d4e4841a061e44e
  - name: quay.io/openshift-release-dev/ocp-release@sha256:61eae2d261e54d1b8a0e05f6b5326228b00468364563745eed88460af04f909b

$ oc apply -f <pis-file>
  1. Create the must-gather from the updated gather_ppc script.
./collection-scripts/gather_ppc
  1. See the resources in the created must-gather.
must-gather
-- cluster-scoped-resources
---- machineconfiguration.openshift.io
...
------ machineconfignodes
-------- ip-10-0-0-9.ec2.internal.yaml
-------- ip-10-0-58-49.ec2.internal.yaml
-------- ip-10-0-7-211.ec2.internal.yaml
-------- ip-10-0-43-205.ec2.internal.yaml
-------- ip-10-0-66-94.ec2.internal.yaml
-------- ip-10-0-78-97.ec2.internal.yaml
...
------ pinnedimagesets
-------- test-pinned.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sferich888
Copy link
Copy Markdown
Contributor

sferich888 commented Apr 28, 2025

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, isabella-janssen, sferich888

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2025
@isabella-janssen
Copy link
Copy Markdown
Member Author

isabella-janssen commented Apr 28, 2025

/label acknowledge-critical-fixes-only

This is a simple change to add resources needed by the MCO team to enable new feature debugging.

@openshift-ci openshift-ci Bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Apr 28, 2025
@openshift-merge-bot openshift-merge-bot Bot merged commit 463c03c into openshift:master Apr 28, 2025
3 of 4 checks passed
@isabella-janssen isabella-janssen deleted the addMCNToMustGather branch April 28, 2025 19:51
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Apr 28, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-must-gather
This PR has been included in build ose-must-gather-container-v4.20.0-202504282214.p0.g463c03c.assembly.stream.el9.
All builds following this will include this PR.

@pablintino pablintino mentioned this pull request Mar 25, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

@sferich888 sferich888 Awaiting requested review from sferich888

Assignees

@sferich888 sferich888

@djoshy djoshy

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@isabella-janssen @openshift-ci-robot @djoshy @sferich888 @openshift-bot