Repository navigation
Conversation
OADP applies nodeAgent.loadAffinity to the NodeAgent DaemonSet, unlike upstream Velero which applies it to data mover pods only. Pod volumes on nodes outside loadAffinity cannot use File System Backup. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Co-Authored-By: Claude Code (model: Claude Opus 5.5) <noreply@anthropic.com>
Contributor
|
Pipeline controller notification This PR uses the pipeline controller for second-stage tests. Selection and triggering follow the repository configuration. Use |
|
Skipping CI for Draft Pull Request. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why the changes were made
OADP applies
spec.configuration.nodeAgent.loadAffinityto the NodeAgent DaemonSet as well as to the data mover pods (internal/controller/nodeagent.go,ReconcileNodeAgentDaemonset). This is intended (seedocs/design/DPA-and-node-selectors.md). Upstream Velero usesloadAffinityfrom the node-agent ConfigMap for data mover pods only, and does not change where node-agent runs.The side effect is not documented: File System Backup (Kopia PodVolumeBackup/PodVolumeRestore) runs in the NodeAgent pod on the node of the workload pod. If
loadAffinityselects a subset of nodes, pod volumes on other nodes cannot use File System Backup.This adds a note to
docs/scheduling_and_node_affinity.mdthat explains the difference from Velero and the File System Backup impact, and that per-StorageClass entries result in the union of all entries for the DaemonSet. No behavior change.How found: live testing on OCP 5.1 EC. With
nodeAgent.loadAffinityselecting one of three workers, node-agent ran on one worker only. Data mover backups/restores worked, but File System Backup could not run for pods on the other workers.How to test the changes made
Docs only. Review the rendered
docs/scheduling_and_node_affinity.md, section "b. Configure NodeAgent Load Affinity".Note
Responses generated with Claude (model: Claude Opus 5.5)
Summary by CodeRabbit