Repository navigation
fix(e2e): read VMB backup type from status.includedVolumes[].type - #2531
Conversation
KubeVirt dropped VirtualMachineBackup.status.type (kubevirt/kubevirt f1a69f53c) in favour of per-volume status.includedVolumes[].type, so GetVMBBackupType never saw a type on current KubeVirt and timed out in the virt-kdm incremental sequence test. Derive the type from the included volumes: Incremental only if every volume is incremental, otherwise Full. This keeps the test checking the backup type virt-controller actually performed rather than the controller's own expected-backup-type annotation. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Tiger Kaovilai <11228024+kaovilai@users.noreply.github.com>
|
Pipeline controller notification This PR uses the pipeline controller for second-stage tests. Selection and triggering follow the repository configuration. Use |
|
Skipping CI for Draft Pull Request. |
Only Full and Incremental are valid; treating any other value as Full could let a full-backup assertion pass without evidence of a full backup. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Tiger Kaovilai <11228024+kaovilai@users.noreply.github.com>
|
/test all |
|
/retest Re-running jobs that failed with S3 403 InvalidAccessKeyId after the CI AWS key was rotated; see #2532. Note Responses generated with Claude (model: Claude Sonnet 5.5) |
|
/retest Re-running jobs that failed with S3 403 InvalidAccessKeyId after the CI AWS key was rotated again; see #2532. Note Responses generated with Claude (model: Claude Sonnet 5.5) |
kubevirt-datamover-controller records one type per checkpoint and keeps a mixed backup (some volumes full, some incremental) incremental so the parent chain is preserved. Mirror that in GetVMBBackupType. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Tiger Kaovilai <11228024+kaovilai@users.noreply.github.com>
|
/test 5.0-e2e-test-aws |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, shubham-pampattiwar, sseago The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
The #2529 fixes this by separating Also note: the AI-generated. Review for accuracy. |
|
The I don't think the restart explanation holds, though, and I'd rather not restructure the test on it yet:
With #255, the expected sequence is chain length 2 after backup 2, still 2 after the restart, 3 after backup 3, then Note Responses generated with Claude (model: Claude Sonnet 5.5) |
|
The #2529 fixes this by separating AI-generated. Review for accuracy. |
|
Agreed—the earlier explanation that the VM restart reset the BSL checkpoint chain was wrong, and I withdraw it. I also verified that the max-incremental count is One timeline clarification from the run: backup 2’s pre-backup lookup had The Prow run imported the prebuilt AI-assisted response AI-generated. Review for accuracy. |
|
@kaovilai A restart keeps the chain in S3, but upon VM restart, the checkpoint in the VM itself gets lost, so while OADP asks for an incremental backup, kubevirt forces a full one, and then our post-kubevirt processing takes "full" from the status and updates the chain accordingly. When I was debugging this particular failure in my own (now closed) PR, that's exactly what I saw happening. Because the restart caused the chain to reset, we didn't hit max chain length. |
|
Although it's not 100% clear what's happening now, and I never really got to see whether the restructuring fixed CI since that's when the tests all stopped working. |
|
/test 5.0-e2e-test-aws |
|
/retest |
|
Two 1. openshift/release#84228 added the step to the 2. The AI-generated. Review for accuracy. |
|
/lgtm |
|
/hold Holding this PR until migtools/kubevirt-datamover-controller#255 merges, per the merge order in this description (that PR first, then this one). Without the hold, tide merges this PR as soon as the Release the hold with Note Responses generated with Claude (model: Claude Sonnet 5.5) |
|
/hold cancel migtools/kubevirt-datamover-controller#255 has merged; releasing this per the hold condition. Note Responses generated with Claude (model: GLM 5.3) |
|
/cherry-pick oadp-1.6 |
|
@sseago: new pull request created: #2540 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
KubeVirt dropped VirtualMachineBackup.status.type (kubevirt/kubevirt f1a69f53c) in favour of per-volume status.includedVolumes[].type, so GetVMBBackupType never saw a type on current KubeVirt and timed out in the virt-kdm incremental sequence test. Derive the type from the included volumes: Incremental only if every volume is incremental, otherwise Full. This keeps the test checking the backup type virt-controller actually performed rather than the controller's own expected-backup-type annotation. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Tiger Kaovilai <11228024+kaovilai@users.noreply.github.com> (cherry picked from commit 51dac1b) backport of openshift#2531 to oadp-1.6 — unblocks the known oadp-1.6 base-branch KDM flake (see PR discussion) Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
…openshift#88443) * Wire Depends-On image overrides into all oadp-operator e2e presubmits Follow-up to openshift#84228, which wired the Depends-On cross-repo image override only into the e2e-test-aws presubmits. Extend the same wiring (DEPENDS_ON_CANDIDATES copied per-branch from that file's e2e-test-aws, oadp-depends-on-build pre-step, oadp-apply-depends-on-images test-step) to every remaining oadp-operator e2e presubmit: - e2e-test-cli-aws (oadp-1.4/1.5/1.6/dev, incl. allnamespaces on 5.1) - virt-kdm-e2e-test-aws / virt-nokdm-e2e-test-aws (oadp-1.6, oadp-dev 5.0) - e2e-test-kubevirt-aws / e2e-test-hcp-aws (oadp-1.5, oadp-1.6) - e2e-test-aws-allnamespaces (oadp-dev 5.1) so a Depends-On: line in a PR description takes effect for the job that actually exercises the affected specs -- e.g. the virt-kdm job needed to validate openshift/oadp-operator#2531 together with migtools/kubevirt-datamover-controller#255 pre-merge. Not wired, deliberately: periodics/postsubmits (no PR description to resolve), tls-pqc-readiness/tls13-adherence scanner jobs, oadp-1.3__4.14 (EOL, also excluded by 84228's scope), and hypershift-oadp-plugin e2e (installs via hypershift workflow + dependency_overrides, not an OLM Subscription). Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Co-Authored-By: Claude Code (model: GLM 5.3) <noreply@anthropic.com> * oadp-depends-on-build: survive GitHub API unavailability and fix body extraction The step failed every job it ran in since openshift#84228 merged, for two independent reasons: 1. The anonymous api.github.com fetch fails from build-farm step pods (their shared egress IP sits over GitHub's anonymous rate limit; observed as an immediate failure in every run so far -- 84228's own rehearsals, the 88443 rehearsal, and openshift/oadp-operator#2531 post-merge e2e-test-aws run, all dying at this step before any test ran). With set -e this turned every wired presubmit red. 2. Even on a successful fetch, the PR-body extraction never matched: GitHub returns pretty-printed JSON ("body": "..." with a space after the colon) but the pattern required "body":" with none, so the extraction came back empty and the grep no-match exit code killed the step under errexit+pipefail. Fixes: - Fetch resilience: 3 direct retries, then 3 retries through a one-shot curl pod on the test cluster's own egress (different NAT IP than the build farm's), then degrade to a no-op with a loud warning and a depends-on-fetch-failed.txt marker artifact -- a broken description fetch must never fail the job itself. - Extraction: tolerate the whitespace after the JSON key and neutralize the grep no-match exit code. Validated locally against openshift/oadp-operator#2531: the fixed extraction finds its Depends-On line naming migtools/kubevirt-datamover-controller#255, and a forced all-fetches-failed run logs the warning, writes the marker, and exits 0. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Co-Authored-By: Claude Code (model: GLM 5.3) <noreply@anthropic.com> * oadp-depends-on-build: align body-prefix strip with the extraction regex The bash glob strip required at least one space after the JSON colon while the extraction regex tolerates zero; a compact payload would have kept its "body":" prefix. Same sed-based regex semantics on both sides now. Review finding on openshift#88443. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Co-Authored-By: Claude Code (model: GLM 5.3) <noreply@anthropic.com> * oadp-depends-on-build: fix SC2155 in fetch fallback pod name Split local declaration from assignment per shellcheck (the only finding from ci/prow/step-registry-shellcheck on openshift#88443). Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Co-Authored-By: Claude Code (model: GLM 5.3) <noreply@anthropic.com> * Address review: mktemp scratch files, bounded fetch curls, 1.5 virt/hcp candidates - oadp-depends-on-build: use mktemp for the PR-JSON/curl-stderr scratch files and the dependency tarball instead of predictable /tmp names (CWE-377), and bound both GitHub fetch curls with connect/max timeouts so a stalled connection cannot block the fallback attempts or the no-op path. The tarball path also moves to mktemp (same pattern, pre-existing from openshift#84228). - oadp-1.5__4.19/4.20: e2e-test-kubevirt-aws gains the migtools/kubevirt-velero-plugin candidate and e2e-test-hcp-aws gains openshift/hypershift-oadp-plugin, so a Depends-On naming those repos resolves on the jobs that actually exercise them (both entries already present in the 1.6/dev lists these were copied from). Review findings on openshift#88443. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Co-Authored-By: Claude Code (model: GLM 5.3) <noreply@anthropic.com> --------- Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Co-authored-by: Claude Code (model: GLM 5.3) <noreply@anthropic.com>
…openshift#88443) * Wire Depends-On image overrides into all oadp-operator e2e presubmits Follow-up to openshift#84228, which wired the Depends-On cross-repo image override only into the e2e-test-aws presubmits. Extend the same wiring (DEPENDS_ON_CANDIDATES copied per-branch from that file's e2e-test-aws, oadp-depends-on-build pre-step, oadp-apply-depends-on-images test-step) to every remaining oadp-operator e2e presubmit: - e2e-test-cli-aws (oadp-1.4/1.5/1.6/dev, incl. allnamespaces on 5.1) - virt-kdm-e2e-test-aws / virt-nokdm-e2e-test-aws (oadp-1.6, oadp-dev 5.0) - e2e-test-kubevirt-aws / e2e-test-hcp-aws (oadp-1.5, oadp-1.6) - e2e-test-aws-allnamespaces (oadp-dev 5.1) so a Depends-On: line in a PR description takes effect for the job that actually exercises the affected specs -- e.g. the virt-kdm job needed to validate openshift/oadp-operator#2531 together with migtools/kubevirt-datamover-controller#255 pre-merge. Not wired, deliberately: periodics/postsubmits (no PR description to resolve), tls-pqc-readiness/tls13-adherence scanner jobs, oadp-1.3__4.14 (EOL, also excluded by 84228's scope), and hypershift-oadp-plugin e2e (installs via hypershift workflow + dependency_overrides, not an OLM Subscription). Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Co-Authored-By: Claude Code (model: GLM 5.3) <noreply@anthropic.com> * oadp-depends-on-build: survive GitHub API unavailability and fix body extraction The step failed every job it ran in since openshift#84228 merged, for two independent reasons: 1. The anonymous api.github.com fetch fails from build-farm step pods (their shared egress IP sits over GitHub's anonymous rate limit; observed as an immediate failure in every run so far -- 84228's own rehearsals, the 88443 rehearsal, and openshift/oadp-operator#2531 post-merge e2e-test-aws run, all dying at this step before any test ran). With set -e this turned every wired presubmit red. 2. Even on a successful fetch, the PR-body extraction never matched: GitHub returns pretty-printed JSON ("body": "..." with a space after the colon) but the pattern required "body":" with none, so the extraction came back empty and the grep no-match exit code killed the step under errexit+pipefail. Fixes: - Fetch resilience: 3 direct retries, then 3 retries through a one-shot curl pod on the test cluster's own egress (different NAT IP than the build farm's), then degrade to a no-op with a loud warning and a depends-on-fetch-failed.txt marker artifact -- a broken description fetch must never fail the job itself. - Extraction: tolerate the whitespace after the JSON key and neutralize the grep no-match exit code. Validated locally against openshift/oadp-operator#2531: the fixed extraction finds its Depends-On line naming migtools/kubevirt-datamover-controller#255, and a forced all-fetches-failed run logs the warning, writes the marker, and exits 0. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Co-Authored-By: Claude Code (model: GLM 5.3) <noreply@anthropic.com> * oadp-depends-on-build: align body-prefix strip with the extraction regex The bash glob strip required at least one space after the JSON colon while the extraction regex tolerates zero; a compact payload would have kept its "body":" prefix. Same sed-based regex semantics on both sides now. Review finding on openshift#88443. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Co-Authored-By: Claude Code (model: GLM 5.3) <noreply@anthropic.com> * oadp-depends-on-build: fix SC2155 in fetch fallback pod name Split local declaration from assignment per shellcheck (the only finding from ci/prow/step-registry-shellcheck on openshift#88443). Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Co-Authored-By: Claude Code (model: GLM 5.3) <noreply@anthropic.com> * Address review: mktemp scratch files, bounded fetch curls, 1.5 virt/hcp candidates - oadp-depends-on-build: use mktemp for the PR-JSON/curl-stderr scratch files and the dependency tarball instead of predictable /tmp names (CWE-377), and bound both GitHub fetch curls with connect/max timeouts so a stalled connection cannot block the fallback attempts or the no-op path. The tarball path also moves to mktemp (same pattern, pre-existing from openshift#84228). - oadp-1.5__4.19/4.20: e2e-test-kubevirt-aws gains the migtools/kubevirt-velero-plugin candidate and e2e-test-hcp-aws gains openshift/hypershift-oadp-plugin, so a Depends-On naming those repos resolves on the jobs that actually exercise them (both entries already present in the 1.6/dev lists these were copied from). Review findings on openshift#88443. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Co-Authored-By: Claude Code (model: GLM 5.3) <noreply@anthropic.com> --------- Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Co-authored-by: Claude Code (model: GLM 5.3) <noreply@anthropic.com>
…ends-On The KDM (kubevirt-datamover-controller/-plugin) virt-kdm-e2e-test-aws jobs run oadp-operator's e2e suite from a pre-built image (konveyor/oadp-operator-e2e-tests), whose build/ci-Dockerfile bakes a release branch's source in. A Depends-On: line naming an openshift/oadp-operator PR therefore only ever swapped the operator's manager image (MANAGER_IMAGE) -- the PR's e2e TEST CODE changes never executed in the KDM job, so a KDM PR whose spec changes live in an unmerged oadp-operator PR (e.g. migtools/kubevirt-datamover-controller#255 needing openshift/oadp-operator#2531 GetVMBBackupType rework) could only be tested from the oadp-operator side, and needed /override otherwise. Add a TESTS_SOURCE sentinel to oadp-depends-on-build's DEPENDS_ON_CANDIDATES: for a matching candidate, the depended-on PR's source tarball is copied to ${SHARED_DIR}/depends-on-tests-source-<org>-<repo>.tar.gz instead of being built as an image, and nothing is appended to depends-on-images.txt (the image-apply consumers never see it). The KDM configs' e2e step unpacks that tarball into a fresh directory when present, verifies it is openshift/oadp-operator source via go.mod, and runs make TEST_VIRT_KDM=true test-e2e from it; with no tarball the baked-in tests run exactly as before. konveyor/oadp-operator-e2e-tests carries the Go toolchain and the repo's make test-e2e dependencies (built FROM quay.io/konveyor/builder with kubectl, virtctl, and pre-downloaded modules baked in), which is what makes this viable. All 4 migtools KDM configs (controller/plugin x oadp-dev/oadp-1.6) declare openshift/oadp-operator TESTS_SOURCE; the controller configs keep their existing MANAGER_IMAGE line so a single Depends-On line resolves both the manager image and the test source. MANAGER_IMAGE behavior is unchanged, and jobs without a matching Depends-On line are unaffected. The openshift-priv KDM mirror configs are left unchanged for a follow-up. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Co-Authored-By: Claude Code (model: GLM 5.3) <noreply@anthropic.com>
…_DIR SHARED_DIR is a ~1 MiB Kubernetes Secret (documented across the step-registry: qe-agent, quay, stackrox, telcov, aro-hcp steps), while openshift/oadp-operator source archives are 10+ MB compressed (PR openshift/oadp-operator#2531 is 11.2 MiB) -- the tarball could never transit it, so the original copy-the-tarball design would have failed the positive path. The resolver now writes a one-line pointer file (${SHARED_DIR}/depends-on-tests-source-<org>-<repo>.txt) containing the depended-on PR's archive URL, and each wired e2e step reads the pointer and fetches the tarball itself: - the pointer must name exactly an openshift/oadp-operator PR archive URL (it decides what gets executed as test code, so anything else fails loudly), - the fetch uses curl --retry and fails loudly rather than silently falling back to baked-in tests, - the go.mod module check is unchanged. The resolver-side tarball fetch is kept as fail-fast validation (and is still required by image candidates). oadp-operator-e2e-tests carries curl (its build/ci-Dockerfile installs kubectl/virtctl with it), so the consuming image is fine. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Co-Authored-By: Claude Code (model: GLM 5.3) <noreply@anthropic.com>
Observed live in the openshift#88500 rehearsal of virt-kdm-e2e-test-aws: in a pj-rehearse run, ci-operator's REPO_OWNER/REPO_NAME/PULL_NUMBER identify the openshift/release PR being rehearsed, not a PR of the repo under test -- so a literal Depends-On line in the release PR's own description gets resolved by the rehearsal (that release PR's example line pulled openshift/oadp-operator#2531 manager image and test source into the rehearsal), and the target repo is always built from its branch head, so a Depends-On-resolved rehearsal tests branch-head code against the depended-on PR's code. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Co-Authored-By: Claude Code (model: GLM 5.3) <noreply@anthropic.com>
…ends-On The KDM (kubevirt-datamover-controller/-plugin) virt-kdm-e2e-test-aws jobs run oadp-operator's e2e suite from a pre-built image (konveyor/oadp-operator-e2e-tests), whose build/ci-Dockerfile bakes a release branch's source in. A Depends-On: line naming an openshift/oadp-operator PR therefore only ever swapped the operator's manager image (MANAGER_IMAGE) -- the PR's e2e TEST CODE changes never executed in the KDM job, so a KDM PR whose spec changes live in an unmerged oadp-operator PR (e.g. migtools/kubevirt-datamover-controller#255 needing openshift/oadp-operator#2531 GetVMBBackupType rework) could only be tested from the oadp-operator side, and needed /override otherwise. Add a TESTS_SOURCE sentinel to oadp-depends-on-build's DEPENDS_ON_CANDIDATES: for a matching candidate, the depended-on PR's source tarball is copied to ${SHARED_DIR}/depends-on-tests-source-<org>-<repo>.tar.gz instead of being built as an image, and nothing is appended to depends-on-images.txt (the image-apply consumers never see it). The KDM configs' e2e step unpacks that tarball into a fresh directory when present, verifies it is openshift/oadp-operator source via go.mod, and runs make TEST_VIRT_KDM=true test-e2e from it; with no tarball the baked-in tests run exactly as before. konveyor/oadp-operator-e2e-tests carries the Go toolchain and the repo's make test-e2e dependencies (built FROM quay.io/konveyor/builder with kubectl, virtctl, and pre-downloaded modules baked in), which is what makes this viable. All 4 migtools KDM configs (controller/plugin x oadp-dev/oadp-1.6) declare openshift/oadp-operator TESTS_SOURCE; the controller configs keep their existing MANAGER_IMAGE line so a single Depends-On line resolves both the manager image and the test source. MANAGER_IMAGE behavior is unchanged, and jobs without a matching Depends-On line are unaffected. The openshift-priv KDM mirror configs are left unchanged for a follow-up. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Co-Authored-By: Claude Code (model: GLM 5.3) <noreply@anthropic.com>
…_DIR SHARED_DIR is a ~1 MiB Kubernetes Secret (documented across the step-registry: qe-agent, quay, stackrox, telcov, aro-hcp steps), while openshift/oadp-operator source archives are 10+ MB compressed (PR openshift/oadp-operator#2531 is 11.2 MiB) -- the tarball could never transit it, so the original copy-the-tarball design would have failed the positive path. The resolver now writes a one-line pointer file (${SHARED_DIR}/depends-on-tests-source-<org>-<repo>.txt) containing the depended-on PR's archive URL, and each wired e2e step reads the pointer and fetches the tarball itself: - the pointer must name exactly an openshift/oadp-operator PR archive URL (it decides what gets executed as test code, so anything else fails loudly), - the fetch uses curl --retry and fails loudly rather than silently falling back to baked-in tests, - the go.mod module check is unchanged. The resolver-side tarball fetch is kept as fail-fast validation (and is still required by image candidates). oadp-operator-e2e-tests carries curl (its build/ci-Dockerfile installs kubectl/virtctl with it), so the consuming image is fine. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Co-Authored-By: Claude Code (model: GLM 5.3) <noreply@anthropic.com>
Observed live in the openshift#88500 rehearsal of virt-kdm-e2e-test-aws: in a pj-rehearse run, ci-operator's REPO_OWNER/REPO_NAME/PULL_NUMBER identify the openshift/release PR being rehearsed, not a PR of the repo under test -- so a literal Depends-On line in the release PR's own description gets resolved by the rehearsal (that release PR's example line pulled openshift/oadp-operator#2531 manager image and test source into the rehearsal), and the target repo is always built from its branch head, so a Depends-On-resolved rehearsal tests branch-head code against the depended-on PR's code. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Co-Authored-By: Claude Code (model: GLM 5.3) <noreply@anthropic.com>
Problem
GetVMBBackupTypereadsVirtualMachineBackup.status.type. KubeVirt removed that field (kubevirt/kubevirtf1a69f53c, "drop the whole-backup type") in favour of per-volumestatus.includedVolumes[].type(c32da47a4). On current KubeVirt (community HCO v1.20.0 invirt-kdm-e2e-test-aws) it is never populated, so "full backup, incremental chain, restart, and max-limit fallback" polls until the ephemeral VMB is deleted and times out after 300s, even though the backup itself succeeded.Change
GetVMBBackupTypederives the type fromstatus.includedVolumes[].type, mirroring kubevirt-datamover-controller (which records one type per checkpoint):Incrementalif any included volume is incremental,Fullonly if every volume is full. Unknown volume types are rejected. There is no fallback tostatus.type; this targets current KubeVirt.Relation to #2529
#2529 avoids the timeout by reading the DataUpload's
expected-backup-typeannotation. That value is written by kubevirt-datamover-controller itself, so the "expected vs. actual backup type must not mismatch" assertion can no longer fail. This PR keeps the test checking the type virt-controller actually performed. It conflicts with #2529 onGetVMBBackupType, so one should supersede the other.Merge order
status.includedVolumes[].type), built into the KDM image that OADP ships and tests with.Merging this PR first is safe but not useful: on current KubeVirt the controller still reports
fullfor incremental backups until migtools/kubevirt-datamover-controller#255 lands, so the incremental assertion here is expected to fail. CI for this PR pulls the KDM fix via theDepends-Online below.Depends-On: migtools/kubevirt-datamover-controller#255
Testing
Compiles and passes
go vet ./tests/e2e/....5.0-virt-kdm-e2e-test-awson0f9ac65, withDepends-Onactive for this job (openshift/release#88443):oadp-depends-on-buildfound theDepends-On:line below, built the head of migtools/kubevirt-datamover-controller#255 (4e755aa) inside the test cluster and swapped it in asRELATED_IMAGE_KUBEVIRT_DATAMOVER_CONTROLLER; the e2e step succeeded: https://prow.ci.openshift.org/view/gs/test-platform-results-public/pr-logs/pull/openshift_oadp-operator/2531/pull-ci-openshift-oadp-operator-oadp-dev-5.0-virt-kdm-e2e-test-aws/2118734212679864320An earlier run of the same job on the same commit, before
Depends-Onworked, ran the stock controller and failed at backup 4 (virt_backup_restore_suite_test.go:926): the stock controller read the removedstatus.type, loggedBackup type mismatch detected ... expected=incremental actual=fullon backups 2 and 3 even though the VMBs reportedFull,Incremental,Incremental, and kept the chain length at 1. That run also shows the helper readsincludedVolumes[].typecorrectly.The
Depends-Online can be dropped once #255 is merged and the shipped KDM image carries the fix.Note
Responses generated with Claude (model: Claude Sonnet 5.5)
🤖 Generated with Claude Code
Summary by CodeRabbit