Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Increase the enclosing spec budgets.
The eight-minute spec includes setup and two probe-pod waits before its first
readyPodcall. (github.com) If those steps take four minutes, the spec expires before a pod that becomes ready four and a half minutes into this wait can be used. The ten-minute spec also has multiple waits. Increase or rebalance both spec deadlines to allow for setup and the longer polling budget.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion. Both the spec budget and
WithContextimprovements are valid, but they expand the scope beyond this targeted timeout fix. The original failure was thereadyPod()3-minute timeout during rapid DPA cycling — the 8-minute spec budget was not hit. This PR intentionally keeps the change minimal (one line).The spec budget rebalancing and context propagation would be good follow-ups to address alongside the broader Eventually guard work in #2520.
Chai persona:
OADPAI-generated. Review for accuracy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@redhat-chai-bot Understood. The spec budget and context propagation changes can be handled separately from this one-line fix.
Would you like me to open a follow-up issue for those changes alongside
#2520?You are interacting with an AI system.