Skip to content

Conversation

@perdasilva
Copy link
Contributor

Problem: The collect-profiles job should only take a few seconds to
run. There are instances, such as when the pod cannot be scheduled,
where the job will not complete in a reasonable amount of time. If
enough jobs are scheduled but unable to run, the number of
scheduled jobs can exceed pod quota limits.

Solution: Given that the collect-profiles job should only take a few
seconds to run and that the job is scheduled to run every 15 minutes,
set the collect-profiles cronJob's spec.concurrencyPolicy to
"Replace" so that only one active collect-profiles pod exists at any
time.

@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Apr 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 5, 2022

@perdasilva: This pull request references Bugzilla bug 2071941, which is invalid:

  • expected dependent Bugzilla bug 2055861 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead
  • expected dependent Bugzilla bug 2055861 to target a release in 4.10.0, 4.10.z, but it targets "4.11.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2071941: Replace collect-profile jobs that haven't completed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 5, 2022
Signed-off-by: Per da Silva <perdasilva@gmail.com>
@perdasilva
Copy link
Contributor Author

perdasilva commented Apr 5, 2022

/cherry-pick release-4.10

@openshift-cherrypick-robot

@perdasilva: once the present PR merges, I will cherry-pick it on top of relase-4.10 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick relase-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from ankitathomas and exdx April 5, 2022 10:09
@perdasilva
Copy link
Contributor Author

/cherry-pick release-4.10

@openshift-cherrypick-robot

@perdasilva: once the present PR merges, I will cherry-pick it on top of release-4.10 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 5, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: perdasilva
To complete the pull request process, please assign anik120 after the PR has been reviewed.
You can assign the PR to them by writing /assign @anik120 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@perdasilva
Copy link
Contributor Author

/hold wait until next week - 4.9 branch is picky atm

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2022
@perdasilva
Copy link
Contributor Author

/test e2e-gcp

@perdasilva perdasilva changed the base branch from release-4.9 to release-4.10 April 5, 2022 14:25
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 5, 2022

@perdasilva: This pull request references Bugzilla bug 2071941, which is invalid:

  • expected the bug to target the "4.10.z" release, but it targets "4.9.z" instead
  • expected dependent Bugzilla bug 2055861 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2071941: Replace collect-profile jobs that haven't completed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@perdasilva perdasilva changed the base branch from release-4.10 to release-4.9 April 5, 2022 14:26
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 5, 2022

@perdasilva: This pull request references Bugzilla bug 2071941, which is invalid:

  • expected the bug to target the "4.9.z" release, but it targets "4.10.z" instead
  • expected dependent Bugzilla bug 2055861 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead
  • expected dependent Bugzilla bug 2055861 to target a release in 4.10.0, 4.10.z, but it targets "4.11.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2071941: Replace collect-profile jobs that haven't completed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@perdasilva perdasilva closed this Apr 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 5, 2022

@perdasilva: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-console-olm 48f533d link true /test e2e-aws-console-olm
ci/prow/e2e-upgrade 48f533d link true /test e2e-upgrade
ci/prow/e2e-gcp 48f533d link true /test e2e-gcp
ci/prow/unit-api 48f533d link true /test unit-api
ci/prow/e2e-aws-olm 48f533d link true /test e2e-aws-olm
ci/prow/unit-registry 48f533d link true /test unit-registry
ci/prow/unit-olm 48f533d link true /test unit-olm
ci/prow/verify 48f533d link true /test verify
ci/prow/images 48f533d link true /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Jul 11, 2023
… environments (openshift#276)

* Updated .gitignore to ignore vscode files.

* Added validation for node affinity boundaries in the CSV.

Upstream-repository: api
Upstream-commit: 0ab3debaba2afcffcf16827798c876c7f35a9477
tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Jul 17, 2023
… environments (openshift#276)

* Updated .gitignore to ignore vscode files.

* Added validation for node affinity boundaries in the CSV.

Upstream-repository: api
Upstream-commit: 0ab3debaba2afcffcf16827798c876c7f35a9477
tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Jul 20, 2023
… environments (openshift#276)

* Updated .gitignore to ignore vscode files.

* Added validation for node affinity boundaries in the CSV.

Upstream-repository: api
Upstream-commit: 0ab3debaba2afcffcf16827798c876c7f35a9477
grokspawn pushed a commit to grokspawn/operator-framework-olm that referenced this pull request Jul 15, 2025
… environments (openshift#276)

* Updated .gitignore to ignore vscode files.

* Added validation for node affinity boundaries in the CSV.
grokspawn pushed a commit to grokspawn/operator-framework-olm that referenced this pull request Jul 15, 2025
… environments (openshift#276)

* Updated .gitignore to ignore vscode files.

* Added validation for node affinity boundaries in the CSV.

Upstream-repository: api
Upstream-commit: 0ab3debaba2afcffcf16827798c876c7f35a9477
grokspawn added a commit to grokspawn/operator-framework-olm that referenced this pull request Jul 16, 2025
Signed-off-by: grokspawn <jordan@nimblewidget.com>
grokspawn added a commit to grokspawn/operator-framework-olm that referenced this pull request Jul 16, 2025
Signed-off-by: grokspawn <jordan@nimblewidget.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants