Register cluster-baremetal-tests-ext in extension registry by jadhaj · Pull Request #31197 · openshift/origin

jadhaj · 2026-05-20T07:40:19Z

Add cluster-baremetal-operator test extension binary to the payload extension registry. This allows baremetal E2E tests to run as part of the OpenShift test suite.

Binary path: /usr/bin/cluster-baremetal-tests-ext.gz
Source: openshift/cluster-baremetal-operator

Companion PR: openshift/cluster-baremetal-operator#607
depends-on: openshift/cluster-baremetal-operator#607

Summary by CodeRabbit

Tests
- Registered an external test binary for the cluster-baremetal-operator payload.
- Enables execution of the bundled external test set for that payload, improving test coverage validation without changing public interfaces.

Add cluster-baremetal-operator test extension binary to the payload extension registry. This allows baremetal E2E tests to run as part of the OpenShift test suite. Binary path: /usr/bin/cluster-baremetal-tests-ext.gz Source: openshift/cluster-baremetal-operator Companion PR: https://github.com/openshift/cluster-baremetal-operator/pull/<PR_NUMBER> Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

openshift-merge-bot · 2026-05-20T07:40:21Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

coderabbitai · 2026-05-20T07:40:41Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 9d9eb409-32ec-4dfb-82c3-ac62e81bc91c

📥 Commits

Reviewing files that changed from the base of the PR and between 428b9a0 and 256b27c.

📒 Files selected for processing (1)

pkg/test/extensions/binary.go

Walkthrough

This PR extends the test binary registry in extensionBinaries by adding a new entry for the cluster-baremetal-operator payload. The entry specifies the binary path as /usr/bin/cluster-baremetal-tests-ext.gz. No other logic, behavior, or exported APIs were modified.

Changes

Baremetal operator test binary registration

Layer / File(s)	Summary
Baremetal operator test binary entry `pkg/test/extensions/binary.go`	New `TestBinary` entry for `cluster-baremetal-operator` is added to the `extensionBinaries` registry, pointing to the gzipped test binary at `/usr/bin/cluster-baremetal-tests-ext.gz`.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title clearly and specifically summarizes the main change: registering a new cluster-baremetal-tests-ext binary in the extension registry.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR adds static registry entries for test binary paths, not Ginkgo test definitions with dynamic names. Check does not apply.
Test Structure And Quality	✅ Passed	PR adds a 4-line registry entry for a test binary in a utility file. No Ginkgo test code exists to review against check requirements.
Microshift Test Compatibility	✅ Passed	PR registers external test binary, not adding Ginkgo test definitions. No It(), Describe(), Context(), When() added in this file.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR only registers an external test binary in a registry, not adding new Ginkgo test definitions. SNO compatibility check applies to new test implementations, not registry entries.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR only adds a test extension binary registry entry. No deployment manifests, operator code, controllers, or scheduling constraints are introduced.
Ote Binary Stdout Contract	✅ Passed	PR only registers external binary; OTE Stdout Contract check applies to binary source code in cluster-baremetal-operator, not this registry entry. Registry entry is syntactically valid.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR only adds a registry entry for external test binary, not Ginkgo test code. File contains no test definitions (It/Describe/Context/When) or IPv4/connectivity assumptions.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2026-05-20T07:41:52Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jadhaj
Once this PR has been reviewed and has the lgtm label, please assign jogeo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2026-05-20T07:48:23Z

@jadhaj: This PR was included in a payload test run from openshift/cluster-baremetal-operator#607
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-metal-ipi-ovn-vmedia-disk-encryption-f7

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/43fe9340-5420-11f1-970d-8a7ad95989b8-0

openshift-ci · 2026-05-20T07:57:24Z

@jadhaj: This PR was included in a payload test run from openshift/cluster-baremetal-operator#607
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-metal-ipi-ovn-vmedia-disk-encryption-f7

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/82618880-5421-11f1-9478-129ee9157c6d-0

jadhaj · 2026-05-20T08:06:23Z

@coderabbitai recheck

coderabbitai · 2026-05-20T08:06:34Z

@jadhaj: I'll recheck the PR now.

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

openshift-merge-bot · 2026-05-20T08:08:35Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

Add build-tests step and copy cluster-baremetal-tests-ext.gz to /usr/bin/ in the container image. This is required for the OTE framework to extract and run the tests. The origin PR (openshift/origin#31197) expects the binary at: /usr/bin/cluster-baremetal-tests-ext.gz Without this, test execution fails with: "extracted binary at path ... does not exist in image" Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

jadhaj · 2026-05-21T17:31:08Z

/retest

jadhaj · 2026-05-21T18:57:06Z

/retest

openshift-ci · 2026-05-21T20:10:34Z

@jadhaj: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-csi	`256b27c`	link	true	`/test e2e-aws-csi`
ci/prow/e2e-vsphere-ovn-upi	`256b27c`	link	true	`/test e2e-vsphere-ovn-upi`
ci/prow/e2e-gcp-csi	`256b27c`	link	true	`/test e2e-gcp-csi`
ci/prow/e2e-aws-ovn-fips	`256b27c`	link	true	`/test e2e-aws-ovn-fips`
ci/prow/e2e-metal-ipi-ovn-ipv6	`256b27c`	link	true	`/test e2e-metal-ipi-ovn-ipv6`
ci/prow/e2e-vsphere-ovn	`256b27c`	link	true	`/test e2e-vsphere-ovn`
ci/prow/e2e-gcp-ovn	`256b27c`	link	true	`/test e2e-gcp-ovn`
ci/prow/e2e-aws-ovn-serial-2of2	`256b27c`	link	true	`/test e2e-aws-ovn-serial-2of2`
ci/prow/e2e-aws-ovn-serial-1of2	`256b27c`	link	true	`/test e2e-aws-ovn-serial-1of2`
ci/prow/e2e-aws-ovn-microshift-serial	`256b27c`	link	true	`/test e2e-aws-ovn-microshift-serial`
ci/prow/e2e-aws-ovn-microshift	`256b27c`	link	true	`/test e2e-aws-ovn-microshift`
ci/prow/e2e-gcp-ovn-upgrade	`256b27c`	link	true	`/test e2e-gcp-ovn-upgrade`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-trt · 2026-05-21T22:24:08Z

Job Failure Risk Analysis for sha: 256b27c

Job Name	Failure Risk
pull-ci-openshift-origin-main-e2e-aws-csi	IncompleteTests Tests for this run (81) are below the historical average (2125): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-fips	IncompleteTests Tests for this run (82) are below the historical average (3897): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift	IncompleteTests Tests for this run (29) are below the historical average (1842): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial	IncompleteTests Tests for this run (29) are below the historical average (974): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2	IncompleteTests Tests for this run (81) are below the historical average (2154): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-2of2	IncompleteTests Tests for this run (81) are below the historical average (2218): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-csi	IncompleteTests Tests for this run (79) are below the historical average (2148): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-ovn	IncompleteTests Tests for this run (79) are below the historical average (3957): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-ovn-upgrade	IncompleteTests Tests for this run (79) are below the historical average (2104): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6	IncompleteTests Tests for this run (73) are below the historical average (2782): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-vsphere-ovn	IncompleteTests Tests for this run (76) are below the historical average (3862): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi	IncompleteTests Tests for this run (75) are below the historical average (3299): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

jadhaj · 2026-05-22T06:29:26Z

@coderabbitai help

coderabbitai · 2026-05-22T06:29:33Z

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

CodeRabbit commands

These commands are invoked using PR/Issue comments.

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai rate limit to show your current review rate limit status.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai evaluate custom pre-merge check --instructions <custom-checks-instructions> --name <custom-checks-title> [--mode <error|warning>] to validate the custom pre-merge checks instructions. Defaults to error when --mode is omitted.
@coderabbitai ignore pre-merge checks to override pre-merge checks and get an approval on PR.
@coderabbitai run pre-merge checks to run pre-merge checks on the pull request.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai emit path instructions to emit generated path-specific review instructions for this repository.
@coderabbitai resolve merge conflict to automatically resolve merge conflicts.
@coderabbitai autofix to automatically fix issues identified in unresolved review comments.
@coderabbitai resolve to resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai generate configuration to create a PR that adds the current resolved configuration as .coderabbit.yaml (or show it if already present).
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, support, documentation and community

Visit our status page to check the current availability of CodeRabbit.
Create a ticket on our support page for assistance with any issues or questions.
Visit our documentation site for detailed information on how to use CodeRabbit.
Join our Discord community to connect with other users and get help from the community.
Follow us on X/Twitter for updates and announcements.

jadhaj · 2026-05-22T06:32:54Z

@coderabbitai full review

coderabbitai · 2026-05-22T06:33:00Z

✅ Actions performed

Full review triggered.

openshift-ci · 2026-05-22T06:41:31Z

@jadhaj: This PR was included in a payload test run from openshift/cluster-baremetal-operator#607
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-metal-ipi-ovn-vmedia-disk-encryption-f7

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4173d420-55a9-11f1-80d3-3c322e744e25-0

openshift-ci · 2026-05-22T07:18:20Z

@jadhaj: This PR was included in a payload test run from openshift/cluster-baremetal-operator#607
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

openshift-ci · 2026-05-22T07:31:55Z

@jadhaj: This PR was included in a payload test run from openshift/cluster-baremetal-operator#607
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-openshift-tests-private-release-4.22-multi-nightly-metal-ipi-ovn-ipv4-amd-f7

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4b70e150-55b0-11f1-8100-f1449358b03c-0

openshift-ci Bot requested review from p0lyn0mial and sjenning May 20, 2026 07:41

jadhaj mentioned this pull request May 20, 2026

Add OpenShift Tests Extension (OTE) for baremetal E2E tests openshift/cluster-baremetal-operator#607

Open

coderabbitai Bot approved these changes May 20, 2026

View reviewed changes

openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label May 20, 2026

Conversation

jadhaj commented May 20, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-merge-bot Bot commented May 20, 2026

Uh oh!

coderabbitai Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

openshift-ci Bot commented May 20, 2026

Uh oh!

openshift-ci Bot commented May 20, 2026

Uh oh!

openshift-ci Bot commented May 20, 2026

Uh oh!

jadhaj commented May 20, 2026

Uh oh!

coderabbitai Bot commented May 20, 2026

Uh oh!

openshift-merge-bot Bot commented May 20, 2026

Uh oh!

jadhaj commented May 21, 2026

Uh oh!

jadhaj commented May 21, 2026

Uh oh!

openshift-ci Bot commented May 21, 2026

Uh oh!

openshift-trt Bot commented May 21, 2026

Uh oh!

jadhaj commented May 22, 2026

Uh oh!

coderabbitai Bot commented May 22, 2026

Chat

CodeRabbit commands

Other keywords and placeholders

Status, support, documentation and community

Uh oh!

jadhaj commented May 22, 2026

Uh oh!

coderabbitai Bot commented May 22, 2026

Uh oh!

openshift-ci Bot commented May 22, 2026

Uh oh!

openshift-ci Bot commented May 22, 2026

Uh oh!

openshift-ci Bot commented May 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jadhaj commented May 20, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 20, 2026 •

edited

Loading