Skip to content

Remove hardcoded Jira config from triage harness - #974

Open
RaphaelBut wants to merge 1 commit into
openshift:masterfrom
RaphaelBut:fix-triage
Open

RaphaelBut wants to merge 1 commit into
openshift:masterfrom
RaphaelBut:fix-triage

Conversation

@RaphaelBut

@RaphaelBut RaphaelBut commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

The custom triage harness unconditionally injected Jira credentials and a Jira-specific sandbox policy, which broke /fs-triage on GitHub issues (JIRA_USER_EMAIL not set on the native dispatch path).

The upstream base harness at 7ab05564 already handles forge-specific credentials via provider-backed overlays (ADR 0065), selecting GitHub or Jira config based on event.source.system. The custom env overrides and sandbox policy were a pre-overlay approach that is no longer needed.

Drop the env block, the policy reference, and the policies/triage.yaml file. The harness now inherits the upstream base policy (filesystem and process restrictions only, no hardcoded network rules) and lets the provider layer handle Jira and GitHub egress conditionally.

Summary by CodeRabbit

  • Configuration Changes
    • Triage selects GitHub or Jira settings based on the event source, while forge credentials and network access come from upstream configuration.
    • Triage no longer uses a dedicated sandbox policy or passes Jira credentials and settings through its own runner configuration.
    • Code harness configuration now retains only the allowed target branch setting; Jira-poll-specific environment overrides have been removed. These settings are no longer managed directly by the harnesses.

@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 4073c260-ae3c-4ce4-87be-facffef4fb9f

📥 Commits

Reviewing files that changed from the base of the PR and between 28ab985 and e66f3af.

📒 Files selected for processing (1)
  • .fullsend/harness/code.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The code and triage harness configurations remove local Jira credential settings. The triage harness also removes its sandbox policy reference, and the triage sandbox policy file is deleted.

Changes

Provider-backed harness configuration

Layer / File(s) Summary
Update harness configuration
.fullsend/harness/code.yaml, .fullsend/harness/triage.yaml, .fullsend/policies/triage.yaml
The code harness retains only the target branch override. The triage harness removes local Jira credential settings and its policy reference. The triage sandbox policy file is deleted, including its filesystem, process, and network rules.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: samanthajayasinghe

Merge Risk: ⚪ Minimal · up to e66f3

The configuration change removes the unconditional Jira settings that affected GitHub triage. No actionable issue is established from the supplied evidence; the change is mergeable after normal checks.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: removal of hardcoded Jira configuration from the triage harness. It is concise, specific, and consistent with the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The pull request changes only two harness YAML files and deletes one sandbox policy file. The diff contains no Ginkgo test declarations or test-title changes, so it introduces no unstable or overly sp…
Test Structure And Quality ✅ Passed The pull request changes only .fullsend/harness/code.yaml, .fullsend/harness/triage.yaml, and deletes .fullsend/policies/triage.yaml. The authoritative diff contains no Ginkgo tests or test-code…
Microshift Test Compatibility ✅ Passed The pull request changes only .fullsend/harness/code.yaml, .fullsend/harness/triage.yaml, and deletes .fullsend/policies/triage.yaml. The authoritative diff adds no Ginkgo e2e tests, so the Micr…
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request changes only three .fullsend YAML files and deletes one YAML policy. The authoritative diff contains no added Ginkgo tests, Go files, or e2e test files. Therefore, the SNO compatibi…
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The pull request changes only .fullsend/harness/code.yaml, .fullsend/harness/triage.yaml, and deletes .fullsend/policies/triage.yaml. These are harness and sandbox configuration files. The…
Ote Binary Stdout Contract ✅ Passed The pull request changes only three YAML harness/policy files. The authoritative diff contains no Go files, OTE suite setup, process-level entry points, or stdout/logging calls. The check is therefore…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The pull request changes only two harness YAML files and deletes one policy YAML file. The authoritative diff adds no Ginkgo tests or test declarations. Therefore, the IPv4 and disconnected-netw…
No-Weak-Crypto ✅ Passed PASS. The PR changes only YAML harness configuration and deletes a sandbox policy. The authoritative diff adds no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or secret-comparison logic. T…
Container-Privileges ✅ Passed PASS. The PR changes only Fullsend harness YAML and deletes a triage policy. The diff adds no privileged, host namespace, SYS_ADMIN, allowPrivilegeEscalation, or root execution settings. The del…
No-Sensitive-Data-In-Logs ✅ Passed The pull request does not add logging or output statements. The added lines are comments only; the configuration changes remove Jira credential environment mappings and delete the Jira sandbox policy.…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RaphaelBut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2026
Both custom harnesses unconditionally injected Jira credentials, a
Jira-specific sandbox policy (triage), and ISSUE_NUMBER/GIT_BOT_EMAIL
workarounds (code), which broke /fs-triage and /fs-code on GitHub
issues (JIRA_USER_EMAIL not set on the native dispatch path).

The upstream base harnesses at 7ab05564 already handle forge-specific
credentials via provider-backed overlays (ADR 0065), selecting GitHub
or Jira config based on event.source.system / runtime.forge. The Jira
poll workflow populates _normalized_event.source.system in its dispatch
records, so the overlays match correctly on both paths.

Drop the env overrides (except CODE_ALLOWED_TARGET_BRANCHES: master,
which is osdctl-specific), the policy reference, and the
policies/triage.yaml file. Both harnesses now inherit the upstream base
policy and let the provider layer handle forge-specific egress
conditionally.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@RaphaelBut

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci

openshift-ci Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

@RaphaelBut: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@RaphaelBut

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@bergmannf

Copy link
Copy Markdown
Contributor

Looks and sounds good to me, but I don't know enough about fullsend and how it works at this level of detail to drop a final LGTM on this.
I'll leave this up to someone more versed in the fullsend ecosystem, but I'm fine adding an LGTM once that's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants