Repository navigation
Remove hardcoded Jira config from triage harness - #974
RaphaelBut wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe code and triage harness configurations remove local Jira credential settings. The triage harness also removes its sandbox policy reference, and the triage sandbox policy file is deleted. ChangesProvider-backed harness configuration
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The configuration change removes the unconditional Jira settings that affected GitHub triage. No actionable issue is established from the supplied evidence; the change is mergeable after normal checks. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RaphaelBut The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Both custom harnesses unconditionally injected Jira credentials, a Jira-specific sandbox policy (triage), and ISSUE_NUMBER/GIT_BOT_EMAIL workarounds (code), which broke /fs-triage and /fs-code on GitHub issues (JIRA_USER_EMAIL not set on the native dispatch path). The upstream base harnesses at 7ab05564 already handle forge-specific credentials via provider-backed overlays (ADR 0065), selecting GitHub or Jira config based on event.source.system / runtime.forge. The Jira poll workflow populates _normalized_event.source.system in its dispatch records, so the overlays match correctly on both paths. Drop the env overrides (except CODE_ALLOWED_TARGET_BRANCHES: master, which is osdctl-specific), the policy reference, and the policies/triage.yaml file. Both harnesses now inherit the upstream base policy and let the provider layer handle forge-specific egress conditionally. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
28ab985 to
e66f3af
Compare
|
/retest |
|
@RaphaelBut: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
Looks and sounds good to me, but I don't know enough about fullsend and how it works at this level of detail to drop a final LGTM on this. |
The custom triage harness unconditionally injected Jira credentials and a Jira-specific sandbox policy, which broke /fs-triage on GitHub issues (JIRA_USER_EMAIL not set on the native dispatch path).
The upstream base harness at 7ab05564 already handles forge-specific credentials via provider-backed overlays (ADR 0065), selecting GitHub or Jira config based on event.source.system. The custom env overrides and sandbox policy were a pre-overlay approach that is no longer needed.
Drop the env block, the policy reference, and the policies/triage.yaml file. The harness now inherits the upstream base policy (filesystem and process restrictions only, no hardcoded network rules) and lets the provider layer handle Jira and GitHub egress conditionally.
Summary by CodeRabbit