Skip to content

Make oadp AllNamespaces e2e jobs manual-trigger-only and move them to 5.1 - #87249

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
Joeavaikath:oadp-allnamespaces-manual-5.1
Oct 20, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
Joeavaikath:oadp-allnamespaces-manual-5.1

Conversation

@Joeavaikath

@Joeavaikath Joeavaikath commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #87092, which added the oadp-operator AllNamespaces e2e presubmits to the 5.0 variant with run_if_changed. Two changes:

  • Manual-trigger-only: drop run_if_changed (keep always_run: false + optional: true) so the jobs never fire automatically and run only via /test 5.1-e2e-test-aws-allnamespaces / /test 5.1-e2e-test-cli-aws-allnamespaces. optional alone only means failures don't block merges — the jobs still auto-triggered on matching pushes, leaving contributors a red check to override. Same shape as other manual-only optional jobs (e.g. kueue-operator upgrade tests).
  • Move from 5.0 to 5.1 per maintainer preference.

Job semantics otherwise unchanged from #87092: OO_TARGET_NAMESPACES: '!all' (global OperatorGroup install) and make TEST_ALLNAMESPACES=true test-e2e (runs the allnamespaces-labeled specs alongside the default suite). Jobs file regenerated via make jobs.

Both jobs passed on openshift/oadp-operator#2488 under the previous (auto-triggering) configuration, validating the job definitions.

Test plan

  • Config validation CI on this PR
  • After merge: /test 5.1-e2e-test-aws-allnamespaces on an oadp-dev PR to confirm manual trigger works

Note: Posted using claude code
Model: GLM 5.3

Summary by CodeRabbit

The oadp-operator oadp-dev CI configuration moves the two optional AllNamespaces e2e presubmits from the 5.0 variant to the 5.1 variant. The jobs retain optional: true and always_run: false, and remove run_if_changed, so users can request them with /test 5.1-e2e-test-aws-allnamespaces or /test 5.1-e2e-test-cli-aws-allnamespaces.

The jobs continue to target all namespaces with OO_TARGET_NAMESPACES: '!all' and run the existing e2e test commands. The provided information reports that both jobs passed under the previous configuration. Config validation CI is pending, and post-merge manual-trigger verification is planned.

… 5.1

The allnamespaces jobs previously carried run_if_changed, so they fired
automatically on matching pushes; being optional only meant their
failures did not block merges, so contributors still saw red checks they
had to override. Drop run_if_changed (always_run stays false) so the
jobs run only via /test, and move them from the 5.0 to the 5.1 variant.
Same shape as other manual-only optional jobs (e.g. kueue-operator
upgrade tests).

Note: Posted using claude code
Model: GLM 5.3
@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository YAML (base), Central YAML (inherited)
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 5045d19e-cd9d-4471-972d-267844b6c20f
📥 Commits

Reviewing files that changed from the base of the PR and between 798cbd6 and 1c6722d.

⛔ Files ignored due to path filters: 1
  • ci-operator/jobs/openshift/oadp-operator/openshift-oadp-operator-oadp-dev-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing: 2
  • ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-dev__5.0.yaml
  • ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-dev__5.1.yaml
💤 Files with no reviewable changes: 1
  • ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-dev__5.0.yaml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

The 5.0 configuration removes two optional AWS all-namespaces e2e jobs. The 5.1 configuration adds the standard and CLI versions of those jobs.

Changes

AWS all-namespaces e2e jobs

Layer / File(s) Summary
Configure standard and CLI AWS jobs
ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-dev__5.1.yaml, ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-dev__5.0.yaml
The 5.1 configuration adds optional standard and CLI AWS jobs that target !all. The 5.0 configuration removes both jobs.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: psalajova

Merge Risk: ⚪ Minimal · up to 1c672

No new merge-blocking issue was established for the job move. The all-namespaces test selection warrants separate follow-up.

Pre-merge checks: Passed 15
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly summarizes the primary changes: moving the OADP AllNamespaces e2e jobs to 5.1 and making them manual-trigger-only.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names Passed The pull request changes only ci-operator YAML configuration and generated Prow job definitions. The diff adds or removes job identifiers such as e2e-test-aws-allnamespaces, but it does not change a…
Test Structure And Quality Passed PASS. The pull request changes only CI YAML configuration and generated presubmit job definitions. The diff adds or moves job wiring, but it adds no Ginkgo test code or new It blocks. Therefore the …
Microshift Test Compatibility Passed The pull request changes only CI YAML configuration and generated presubmit YAML. The authoritative diff contains no added Go test files or Ginkgo declarations such as It, Describe, Context, or When. …
Single Node Openshift (Sno) Test Compatibility Passed The pull request changes only CI YAML and generated presubmit job definitions. It adds no Ginkgo test code or new It/Describe/Context/When blocks. Therefore, the SNO compatibility check is not applica…
Topology-Aware Scheduling Compatibility Passed PASS: The pull request changes only ci-operator test configuration and generated Prow presubmit job definitions. It does not modify deployment manifests, operator code, controllers, replica logic, aff…
Ote Binary Stdout Contract Passed PASS: The pull request changes only ci-operator configuration and generated job YAML files. It does not change an OTE binary or process-level Go code, so it introduces no checked stdout writes.
Ipv6 And Disconnected Network Test Compatibility Passed PASS: The pull request changes only ci-operator YAML configuration and generated presubmit definitions. It adds no Ginkgo test declarations or test implementation code, and the added lines contain no …
No-Weak-Crypto Passed The pull request changes only CI YAML job definitions and generated presubmit metadata. The added and modified lines contain no MD5, SHA1, DES, 3DES, RC4, Blowfish, ECB, custom cryptography, or secret…
Container-Privileges Passed No container privilege settings were introduced. The added 5.1 jobs and generated Prow jobs contain no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or ro…
No-Sensitive-Data-In-Logs Passed PASS. The PR only moves two AWS e2e job definitions from 5.0 to 5.1 and removes run_if_changed. The added jobs reference existing credential mounts and secret paths, but add no logging commands, log…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Stable And Deterministic Test Names

Explanation

The pull request changes only ci-operator YAML configuration and generated Prow job definitions. The diff adds or removes job identifiers such as e2e-test-aws-allnamespaces, but it does not change any Ginkgo It, Describe, Context, or When test title. Therefore, this check is not applicable and finds no unstable test name.

Full details: Test Structure And Quality

Explanation

PASS. The pull request changes only CI YAML configuration and generated presubmit job definitions. The diff adds or moves job wiring, but it adds no Ginkgo test code or new It blocks. Therefore the listed test-structure requirements do not apply.

Full details: Microshift Test Compatibility

Explanation

The pull request changes only CI YAML configuration and generated presubmit YAML. The authoritative diff contains no added Go test files or Ginkgo declarations such as It, Describe, Context, or When. It therefore introduces no Ginkgo test requiring MicroShift compatibility review.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

The pull request changes only CI YAML and generated presubmit job definitions. It adds no Ginkgo test code or new It/Describe/Context/When blocks. Therefore, the SNO compatibility check is not applicable.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The pull request changes only ci-operator test configuration and generated Prow presubmit job definitions. It does not modify deployment manifests, operator code, controllers, replica logic, affinity, topology spread, node selectors, tolerations, or PDBs. The added jobs define CI execution settings only, so the topology-aware scheduling failure conditions do not apply.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS: The pull request changes only ci-operator YAML configuration and generated presubmit definitions. It adds no Ginkgo test declarations or test implementation code, and the added lines contain no IPv4 literals, IPv4-only parsing, or external connectivity commands or URLs. Existing e2e suites are only moved to the 5.1 manual jobs.

Full details: No-Weak-Crypto

Explanation

The pull request changes only CI YAML job definitions and generated presubmit metadata. The added and modified lines contain no MD5, SHA1, DES, 3DES, RC4, Blowfish, ECB, custom cryptography, or secret/token comparisons. No weak-crypto usage is introduced.

Full details: Container-Privileges

Explanation

No container privilege settings were introduced. The added 5.1 jobs and generated Prow jobs contain no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root security-context fields. They use the same standard test-oadp-operator test step and ci-operator job container pattern as existing jobs.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS. The PR only moves two AWS e2e job definitions from 5.0 to 5.1 and removes run_if_changed. The added jobs reference existing credential mounts and secret paths, but add no logging commands, log configuration, literal credentials, tokens, passwords, PII, hostnames, or customer data. The test commands are unchanged in behavior and no application logging code changes are present.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@Joeavaikath: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-oadp-operator-oadp-dev-5.1-e2e-test-aws-allnamespaces openshift/oadp-operator presubmit Presubmit changed
pull-ci-openshift-oadp-operator-oadp-dev-5.1-e2e-test-cli-aws-allnamespaces openshift/oadp-operator presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2026
@Joeavaikath

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Joeavaikath: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

@Joeavaikath: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/oadp-operator/oadp-dev/5.1-e2e-test-aws-allnamespaces 1c6722d link unknown /pj-rehearse pull-ci-openshift-oadp-operator-oadp-dev-5.1-e2e-test-aws-allnamespaces
ci/rehearse/openshift/oadp-operator/oadp-dev/5.1-e2e-test-cli-aws-allnamespaces 1c6722d link unknown /pj-rehearse pull-ci-openshift-oadp-operator-oadp-dev-5.1-e2e-test-cli-aws-allnamespaces

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Joeavaikath

Copy link
Copy Markdown
Contributor Author

Test failed as expected with
[2026-10-19T15:19:40.517Z] ClusterServiceVersion oadp-operator.v99.0.0 status message: AllNamespaces InstallModeType not supported, cannot configure to watch all namespaces

@kaovilai kaovilai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kaovilai

Copy link
Copy Markdown
Member

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 19, 2026
@openshift-ci

openshift-ci Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Joeavaikath, kaovilai, shubham-pampattiwar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit fa2c140 into openshift:main Oct 20, 2026
18 of 20 checks passed
rasrivastava pushed a commit to rasrivastava/release that referenced this pull request Nov 3, 2026
… 5.1 (openshift#87249)

The allnamespaces jobs previously carried run_if_changed, so they fired
automatically on matching pushes; being optional only meant their
failures did not block merges, so contributors still saw red checks they
had to override. Drop run_if_changed (always_run stays false) so the
jobs run only via /test, and move them from the 5.0 to the 5.1 variant.
Same shape as other manual-only optional jobs (e.g. kueue-operator
upgrade tests).

Note: Posted using claude code
Model: GLM 5.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants