Repository navigation
Make oadp AllNamespaces e2e jobs manual-trigger-only and move them to 5.1 - #87249
openshift-merge-bot[bot] merged 1 commit into
Conversation
… 5.1 The allnamespaces jobs previously carried run_if_changed, so they fired automatically on matching pushes; being optional only meant their failures did not block merges, so contributors still saw red checks they had to override. Drop run_if_changed (always_run stays false) so the jobs run only via /test, and move them from the 5.0 to the 5.1 variant. Same shape as other manual-only optional jobs (e.g. kueue-operator upgrade tests). Note: Posted using claude code Model: GLM 5.3
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse |
|
@Joeavaikath: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@Joeavaikath: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Test failed as expected with |
|
/pj-rehearse ack |
|
@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Joeavaikath, kaovilai, shubham-pampattiwar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fa2c140
into
openshift:main
… 5.1 (openshift#87249) The allnamespaces jobs previously carried run_if_changed, so they fired automatically on matching pushes; being optional only meant their failures did not block merges, so contributors still saw red checks they had to override. Drop run_if_changed (always_run stays false) so the jobs run only via /test, and move them from the 5.0 to the 5.1 variant. Same shape as other manual-only optional jobs (e.g. kueue-operator upgrade tests). Note: Posted using claude code Model: GLM 5.3
Summary
Follow-up to #87092, which added the oadp-operator AllNamespaces e2e presubmits to the 5.0 variant with
run_if_changed. Two changes:run_if_changed(keepalways_run: false+optional: true) so the jobs never fire automatically and run only via/test 5.1-e2e-test-aws-allnamespaces//test 5.1-e2e-test-cli-aws-allnamespaces.optionalalone only means failures don't block merges — the jobs still auto-triggered on matching pushes, leaving contributors a red check to override. Same shape as other manual-only optional jobs (e.g. kueue-operator upgrade tests).Job semantics otherwise unchanged from #87092:
OO_TARGET_NAMESPACES: '!all'(global OperatorGroup install) andmake TEST_ALLNAMESPACES=true test-e2e(runs the allnamespaces-labeled specs alongside the default suite). Jobs file regenerated viamake jobs.Both jobs passed on openshift/oadp-operator#2488 under the previous (auto-triggering) configuration, validating the job definitions.
Test plan
/test 5.1-e2e-test-aws-allnamespaceson an oadp-dev PR to confirm manual trigger worksNote: Posted using claude code
Model: GLM 5.3
Summary by CodeRabbit
The oadp-operator
oadp-devCI configuration moves the two optional AllNamespaces e2e presubmits from the 5.0 variant to the 5.1 variant. The jobs retainoptional: trueandalways_run: false, and removerun_if_changed, so users can request them with/test 5.1-e2e-test-aws-allnamespacesor/test 5.1-e2e-test-cli-aws-allnamespaces.The jobs continue to target all namespaces with
OO_TARGET_NAMESPACES: '!all'and run the existing e2e test commands. The provided information reports that both jobs passed under the previous configuration. Config validation CI is pending, and post-merge manual-trigger verification is planned.