Repository navigation
docs: CTRange direction inversion, side effects and persistence - #2291
Open
paoloantinori wants to merge 3 commits into
Open
paoloantinori wants to merge 3 commits into
paoloantinori wants to merge 3 commits into
Conversation
Extends the CTRange command description: reversed ranges invert the temperature direction on CCT hardware with swapped channels, and the values do not survive a reboot, so CTRange belongs in the startup command. gate-exempt: documentation-only change (cmddetail comment block)
Adds the caveats found in review: relative temperature commands degenerate while the range is reversed, the current temperature snaps to the new max without an MQTT update, the channel swap is the persistent fix when it works (it did not in my tests on flag-8 CCT hardware), and the reapplied value goes in autoexec.bat or the short startup command. Example without the inline comment. gate-exempt: documentation-only change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Extends the
CTRangecommand description in the//cmddetailblock ofsrc/cmnds/cmd_newLEDDriver.c, which is wherescripts/getcommands.jsregeneratesdocs/commands.mdanddocs/commands-extended.mdfrom.Why
I used
CTRange 500 154to invert the temperature direction on LEDVANCE Smart+ AC33908 CCT bulbs (OpenBeken 1.18.219) whose warm and cold channels map backwards, and none of this behavior was documented: the direction inversion, the fact that the value does not survive a reboot, or the side effects.What the new text states
add_temperature, SmartButtonForLEDs hold) degenerate: in clamp mode every adjustment lands on the new max, in wrap mode the value flips between the endpointsled_temperatureupdate, so the published state goes staleautoexec.bator the short startup commandThe example stays a bare command line, matching the other 62 examples in the generated tables.