Skip to content

Touchup2#5

Closed
trevp wants to merge 2 commits intoopenssl:masterfrom
trevp:touchup2
Closed

Touchup2#5
trevp wants to merge 2 commits intoopenssl:masterfrom
trevp:touchup2

Conversation

@trevp
Copy link
Copy Markdown

@trevp trevp commented Jun 25, 2013

Some comments and cosmetic touchups to custom extension code.

@benlaurie
Copy link
Copy Markdown
Contributor

Merged.

@benlaurie benlaurie closed this Sep 5, 2013
tomato42 referenced this pull request in tomato42/openssl May 24, 2015
Fixed issue #5
Cleaned up code of ssl/t1_enc.c a bit
Please note that this file still isn't completely up-to-date (merged)
with the official 1.0.2 branch
levitte pushed a commit to openssl/tools that referenced this pull request Dec 8, 2017
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from openssl/openssl#5)
@ttandqq ttandqq mentioned this pull request May 28, 2019
@mspncp mspncp mentioned this pull request Aug 14, 2019
2 tasks
bernd-edlinger added a commit to bernd-edlinger/openssl that referenced this pull request May 30, 2023
$ ERROR_INJECT=1668583266 ../util/shlib_wrap.sh ./asn1-test ./corpora/asn1/fa3e83c6324c9ae936e6e66b09e155aae02d67ee
    #0 0x7f42fc532d4f in __sanitizer_print_stack_trace ../../../../src/libsanitizer/asan/asan_stack.cc:36
    openssl#1 0x55c2f6f48bf4 in my_realloc fuzz/test-corpus.c:129
    openssl#2 0x7f42fb1c91e7 in ASN1_STRING_set crypto/asn1/asn1_lib.c:297
    openssl#3 0x7f42fb1a6939 in asn1_string_set_int64 crypto/asn1/a_int.c:350
    openssl#4 0x7f42fb1a6939 in ASN1_INTEGER_set_int64 crypto/asn1/a_int.c:520
    openssl#5 0x7f42fb1dc399 in PKCS8_pkey_set0 crypto/asn1/p8_pkey.c:43
    openssl#6 0x7f42fb59def7 in rsa_priv_encode crypto/rsa/rsa_ameth.c:171
    openssl#7 0x7f42fb4b6994 in EVP_PKEY2PKCS8 crypto/evp/evp_pkey.c:71
    openssl#8 0x7f42fb1d9dfb in i2d_PrivateKey crypto/asn1/i2d_pr.c:23
    openssl#9 0x55c2f6f4814f in FuzzerTestOneInput fuzz/asn1.c:345
    openssl#10 0x55c2f6f48789 in testfile fuzz/test-corpus.c:182
    openssl#11 0x55c2f6f466ef in main fuzz/test-corpus.c:226
    openssl#12 0x7f42f9f32082 in __libc_start_main ../csu/libc-start.c:308
    openssl#13 0x55c2f6f4689d in _start (.../openssl-111-features/fuzz/asn1-test+0x889d)

=================================================================
==624788==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 46 byte(s) in 1 object(s) allocated from:
    #0 0x7f42fc525808 in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cc:144
    openssl#1 0x7f42fb1eaa0b in asn1_item_flags_i2d crypto/asn1/tasn_enc.c:64
    openssl#2 0x7f42fb1eaa0b in ASN1_item_i2d crypto/asn1/tasn_enc.c:44
    openssl#3 0x7f42fb59ddea in rsa_priv_encode crypto/rsa/rsa_ameth.c:163
    openssl#4 0x7f42fb4b6994 in EVP_PKEY2PKCS8 crypto/evp/evp_pkey.c:71
    openssl#5 0x7f42fb1d9dfb in i2d_PrivateKey crypto/asn1/i2d_pr.c:23
    openssl#6 0x55c2f6f4814f in FuzzerTestOneInput fuzz/asn1.c:345
    openssl#7 0x55c2f6f48789 in testfile fuzz/test-corpus.c:182
    openssl#8 0x55c2f6f466ef in main fuzz/test-corpus.c:226
    openssl#9 0x7f42f9f32082 in __libc_start_main ../csu/libc-start.c:308

SUMMARY: AddressSanitizer: 46 byte(s) leaked in 1 allocation(s).
bernd-edlinger added a commit to bernd-edlinger/openssl that referenced this pull request Jul 19, 2023
$ ERROR_INJECT=1668583266 ../util/shlib_wrap.sh ./asn1-test ./corpora/asn1/fa3e83c6324c9ae936e6e66b09e155aae02d67ee
    #0 0x7f42fc532d4f in __sanitizer_print_stack_trace ../../../../src/libsanitizer/asan/asan_stack.cc:36
    openssl#1 0x55c2f6f48bf4 in my_realloc fuzz/test-corpus.c:129
    openssl#2 0x7f42fb1c91e7 in ASN1_STRING_set crypto/asn1/asn1_lib.c:297
    openssl#3 0x7f42fb1a6939 in asn1_string_set_int64 crypto/asn1/a_int.c:350
    openssl#4 0x7f42fb1a6939 in ASN1_INTEGER_set_int64 crypto/asn1/a_int.c:520
    openssl#5 0x7f42fb1dc399 in PKCS8_pkey_set0 crypto/asn1/p8_pkey.c:43
    openssl#6 0x7f42fb59def7 in rsa_priv_encode crypto/rsa/rsa_ameth.c:171
    openssl#7 0x7f42fb4b6994 in EVP_PKEY2PKCS8 crypto/evp/evp_pkey.c:71
    openssl#8 0x7f42fb1d9dfb in i2d_PrivateKey crypto/asn1/i2d_pr.c:23
    openssl#9 0x55c2f6f4814f in FuzzerTestOneInput fuzz/asn1.c:345
    openssl#10 0x55c2f6f48789 in testfile fuzz/test-corpus.c:182
    openssl#11 0x55c2f6f466ef in main fuzz/test-corpus.c:226
    openssl#12 0x7f42f9f32082 in __libc_start_main ../csu/libc-start.c:308
    openssl#13 0x55c2f6f4689d in _start (.../openssl-111-features/fuzz/asn1-test+0x889d)

=================================================================
==624788==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 46 byte(s) in 1 object(s) allocated from:
    #0 0x7f42fc525808 in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cc:144
    openssl#1 0x7f42fb1eaa0b in asn1_item_flags_i2d crypto/asn1/tasn_enc.c:64
    openssl#2 0x7f42fb1eaa0b in ASN1_item_i2d crypto/asn1/tasn_enc.c:44
    openssl#3 0x7f42fb59ddea in rsa_priv_encode crypto/rsa/rsa_ameth.c:163
    openssl#4 0x7f42fb4b6994 in EVP_PKEY2PKCS8 crypto/evp/evp_pkey.c:71
    openssl#5 0x7f42fb1d9dfb in i2d_PrivateKey crypto/asn1/i2d_pr.c:23
    openssl#6 0x55c2f6f4814f in FuzzerTestOneInput fuzz/asn1.c:345
    openssl#7 0x55c2f6f48789 in testfile fuzz/test-corpus.c:182
    openssl#8 0x55c2f6f466ef in main fuzz/test-corpus.c:226
    openssl#9 0x7f42f9f32082 in __libc_start_main ../csu/libc-start.c:308

SUMMARY: AddressSanitizer: 46 byte(s) leaked in 1 allocation(s).
bernd-edlinger added a commit to bernd-edlinger/openssl that referenced this pull request Aug 1, 2023
$ ERROR_INJECT=1668583266 ../util/shlib_wrap.sh ./asn1-test ./corpora/asn1/fa3e83c6324c9ae936e6e66b09e155aae02d67ee
    #0 0x7f42fc532d4f in __sanitizer_print_stack_trace ../../../../src/libsanitizer/asan/asan_stack.cc:36
    openssl#1 0x55c2f6f48bf4 in my_realloc fuzz/test-corpus.c:129
    openssl#2 0x7f42fb1c91e7 in ASN1_STRING_set crypto/asn1/asn1_lib.c:297
    openssl#3 0x7f42fb1a6939 in asn1_string_set_int64 crypto/asn1/a_int.c:350
    openssl#4 0x7f42fb1a6939 in ASN1_INTEGER_set_int64 crypto/asn1/a_int.c:520
    openssl#5 0x7f42fb1dc399 in PKCS8_pkey_set0 crypto/asn1/p8_pkey.c:43
    openssl#6 0x7f42fb59def7 in rsa_priv_encode crypto/rsa/rsa_ameth.c:171
    openssl#7 0x7f42fb4b6994 in EVP_PKEY2PKCS8 crypto/evp/evp_pkey.c:71
    openssl#8 0x7f42fb1d9dfb in i2d_PrivateKey crypto/asn1/i2d_pr.c:23
    openssl#9 0x55c2f6f4814f in FuzzerTestOneInput fuzz/asn1.c:345
    openssl#10 0x55c2f6f48789 in testfile fuzz/test-corpus.c:182
    openssl#11 0x55c2f6f466ef in main fuzz/test-corpus.c:226
    openssl#12 0x7f42f9f32082 in __libc_start_main ../csu/libc-start.c:308
    openssl#13 0x55c2f6f4689d in _start (.../openssl-111-features/fuzz/asn1-test+0x889d)

=================================================================
==624788==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 46 byte(s) in 1 object(s) allocated from:
    #0 0x7f42fc525808 in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cc:144
    openssl#1 0x7f42fb1eaa0b in asn1_item_flags_i2d crypto/asn1/tasn_enc.c:64
    openssl#2 0x7f42fb1eaa0b in ASN1_item_i2d crypto/asn1/tasn_enc.c:44
    openssl#3 0x7f42fb59ddea in rsa_priv_encode crypto/rsa/rsa_ameth.c:163
    openssl#4 0x7f42fb4b6994 in EVP_PKEY2PKCS8 crypto/evp/evp_pkey.c:71
    openssl#5 0x7f42fb1d9dfb in i2d_PrivateKey crypto/asn1/i2d_pr.c:23
    openssl#6 0x55c2f6f4814f in FuzzerTestOneInput fuzz/asn1.c:345
    openssl#7 0x55c2f6f48789 in testfile fuzz/test-corpus.c:182
    openssl#8 0x55c2f6f466ef in main fuzz/test-corpus.c:226
    openssl#9 0x7f42f9f32082 in __libc_start_main ../csu/libc-start.c:308

SUMMARY: AddressSanitizer: 46 byte(s) leaked in 1 allocation(s).
@paulidale paulidale mentioned this pull request Mar 6, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants