Rewrite search results URL when scrolling and restore sidebar position#6895
Open
Arpan200502 wants to merge 1 commit intoopenstreetmap:masterfrom
Open
Rewrite search results URL when scrolling and restore sidebar position#6895Arpan200502 wants to merge 1 commit intoopenstreetmap:masterfrom
Arpan200502 wants to merge 1 commit intoopenstreetmap:masterfrom
Conversation
f5f58a7 to
091ec16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the search results sidebar so that the URL reflects the user's scroll position and browser back navigation restores the approximate location in the results list.
Previously, when navigating back from a search result, the search page would reload and start from the top of the list.
This change introduces scroll state tracking similar to the behavior implemented for the history page.
How it works
Scroll detection
IntersectionObserverwatches.search_results_entryitems inside the sidebar.URL state
OSM.router.replace()so history is preserved without creating extra entries.Scroll restoration
/search?...&before=<key>via the browser back button:Observer safety
Result
Users can now:
The sidebar will return close to the previous scroll position instead of restarting at the top.
Demo
A short video demonstrating the behavior is attached below.
Steps shown:
bankUntitled.design.1.1.mp4
Closes
Fixes #6893