Skip to content

feat: support override default contentType for WebFBundle. #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andycall merged 1 commit into from
Jan 17, 2024
Merged

feat: support override default contentType for WebFBundle. #534

andycall merged 1 commit into from
Jan 17, 2024

Conversation

@andycall
Copy link
Member

@andycall andycall commented Dec 10, 2023

Support override the default content-type for WebFBundle.

bundle: WebFBundle.fromUrl('assets:assets/bundle.xhtml', contentType: htmlContentType), // This XHTML will treated as HTML file.

ErosZy
ErosZy approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@ErosZy ErosZy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@andycall andycall added this pull request to the merge queue Jan 17, 2024
Merged via the queue into main with commit 063a13a Jan 17, 2024
@andycall andycall deleted the feat/bundle_content_type branch January 17, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@devjiangzhou devjiangzhou devjiangzhou approved these changes

@ErosZy ErosZy ErosZy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andycall @devjiangzhou @ErosZy