Fix: fix ui command exec order in dedicated thread mode.#540
Merged
Conversation
andycall
force-pushed
the
fix/ui_command_order
branch
from
2d8377f to
c6a554a
Compare
yifei8
approved these changes
Jan 16, 2024
andycall
force-pushed
the
fix/ui_command_order
branch
from
0df2015 to
b1c1315
Compare
ErosZy
approved these changes
Jan 18, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
andycall
force-pushed
the
fix/ui_command_order
branch
from
56631a8 to
3d490ea
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
andycall
force-pushed
the
fix/ui_command_order
branch
from
1644bbd to
98799ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UICommands, generated from the JS thread, have the potential to be executed unexpected in the UI thread.
This patch simulates the UICommand execution behavior, as in single-thread mode, to maintain consistent rendering results.