Skip to content

fix: fix memory leak caused by img element. #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yifei8 merged 2 commits into from
Apr 1, 2024
Merged

fix: fix memory leak caused by img element. #590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
639ac35
fix: fix memory leak caused by img element.
andycall Mar 28, 2024
0ac7178
Committing clang-format changes
Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions bridge/core/html/html_image_element.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,14 @@ DispatchEventResult HTMLImageElement::FireEventListeners(Event& event, Exception
return HTMLElement::FireEventListeners(event, exception_state);
}

DispatchEventResult HTMLImageElement::FireEventListeners(webf::Event& event,
bool isCapture,
webf::ExceptionState& exception_state) {
if (event.type() == event_type_names::kload || event.type() == event_type_names::kerror) {
ReleaseAlive();
}

return HTMLElement::FireEventListeners(event, isCapture, exception_state);
}

} // namespace webf
1 change: 1 addition & 0 deletions bridge/core/html/html_image_element.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ class HTMLImageElement : public HTMLElement {
void setSrc(const AtomicString& value, ExceptionState& exception_state);

DispatchEventResult FireEventListeners(Event&, ExceptionState&) override;
DispatchEventResult FireEventListeners(Event&, bool isCapture, ExceptionState&) override;

ScriptPromise decode(ExceptionState& exception_state) const;

Expand Down
2 changes: 1 addition & 1 deletion bridge/foundation/profiler.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@
#ifndef WEBF_FOUNDATION_PROFILER_H_
#define WEBF_FOUNDATION_PROFILER_H_

#include <vector>
#include <memory>
#include <stack>
#include <string>
#include <unordered_map>
#include <vector>
#include "bindings/qjs/script_value.h"
#include "foundation/stop_watch.h"

Expand Down