rpcd-mod-rrdns/luci: lower cmake_minimum_required to 3.13#8608
Open
Yepday wants to merge 1 commit intoopenwrt:masterfrom
Open
rpcd-mod-rrdns/luci: lower cmake_minimum_required to 3.13#8608Yepday wants to merge 1 commit intoopenwrt:masterfrom
Yepday wants to merge 1 commit intoopenwrt:masterfrom
Conversation
These packages only use basic CMake directives available since 2.x. Requiring VERSION 3.31 breaks builds on common environments like Ubuntu 22.04 which ships CMake 3.26. Signed-off-by: Yepday <365256281@qq.com>
Failed checksIssues marked with an ❌ are failing checks. Commit a1b1c48
For more details, see the full job log. Something broken? Consider providing feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request details
Description
These packages only use basic CMake directives available since 2.x.
Requiring VERSION 3.31 breaks builds on common environments like
Ubuntu 22.04 which ships CMake 3.26.
Maintainer (preferred)
@jow-
Tested on
OpenWrt version: OpenWrt 23.05-SNAPSHOT
Checklist
Signed-off-by: Yepday <365256281@qq.com>row (viagit commit --signoff).<package name>: titlefirst line subject for packages.PKG_VERSIONin the Makefile.