Skip to content

rpcd-mod-rrdns/luci: lower cmake_minimum_required to 3.13#8608

Open
Yepday wants to merge 1 commit intoopenwrt:masterfrom
Yepday:fix/cmake-minimum-version
Open

rpcd-mod-rrdns/luci: lower cmake_minimum_required to 3.13#8608
Yepday wants to merge 1 commit intoopenwrt:masterfrom
Yepday:fix/cmake-minimum-version

Conversation

@Yepday
Copy link
Copy Markdown

@Yepday Yepday commented May 4, 2026

Pull request details

Description

These packages only use basic CMake directives available since 2.x.
Requiring VERSION 3.31 breaks builds on common environments like
Ubuntu 22.04 which ships CMake 3.26.

Maintainer (preferred)

@jow-


Tested on

OpenWrt version: OpenWrt 23.05-SNAPSHOT


Checklist

  • This PR is not from my main or master branch 💩, but a separate branch. ✅
  • Each commit has a valid ✒️ Signed-off-by: Yepday <365256281@qq.com> row (via git commit --signoff).
  • Each commit and PR title has a valid 📝 <package name>: title first line subject for packages.
  • Incremented 🆙 any PKG_VERSION in the Makefile.

These packages only use basic CMake directives available since 2.x.
Requiring VERSION 3.31 breaks builds on common environments like
Ubuntu 22.04 which ships CMake 3.26.

Signed-off-by: Yepday <365256281@qq.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Warning

Some formality checks failed.

Consider (re)reading submissions guidelines.

Failed checks

Issues marked with an ❌ are failing checks.

Commit a1b1c48

  • 🔶 Author name must be either a real name 'firstname lastname' or a nickname/alias/handle
    Actual: Yepday seems to be a nickname or an alias
    Expected: a real name 'firstname lastname'
  • 🔶 Commit(ter) name must be either a real name 'firstname lastname' or a nickname/alias/handle
    Actual: Yepday seems to be a nickname or an alias
    Expected: a real name 'firstname lastname'

For more details, see the full job log.

Something broken? Consider providing feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant