Skip to content

luci-base: fix "null" text appearing in modal#8616

Open
AndyChiang888 wants to merge 1 commit intoopenwrt:masterfrom
AndyChiang888:ui.js
Open

luci-base: fix "null" text appearing in modal#8616
AndyChiang888 wants to merge 1 commit intoopenwrt:masterfrom
AndyChiang888:ui.js

Conversation

@AndyChiang888
Copy link
Copy Markdown

fix "null" text appearing in modal

Pull request details

Description

Screenshot or video of changes (if applicable)

Maintainer (preferred)

@


Tested on

OpenWrt version: SNAPSHOT
LuCI version: master
Web browser(s): Chrome 147.0.7727.102


Checklist

  • This PR is not from my main or master branch 💩, but a separate branch. ✅
  • Each commit has a valid ✒️ Signed-off-by: <my@email.address> row (via git commit --signoff).
  • Each commit and PR title has a valid 📝 <package name>: title first line subject for packages.
  • Incremented 🆙 any PKG_VERSION in the Makefile.
  • (Optional) Includes what Issue it closes (e.g. openwrt/luci#issue-number).
  • (Optional) Includes what it depends on (e.g. openwrt/packages#pr-number in sister repo).

@AndyChiang888 AndyChiang888 force-pushed the ui.js branch 3 times, most recently from ca52e73 to d1d7e30 Compare May 10, 2026 14:46
@systemcrash
Copy link
Copy Markdown
Contributor

Looks like an acceptable fix @feckert

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Copy Markdown

Warning

Some formality checks failed.

Consider (re)reading submissions guidelines.

Failed checks

Issues marked with an ❌ are failing checks.

Commit d1d7e30

  • Signed-off-by must match author
    Actual: missing or doesn't match author
    Expected: Signed-off-by: Andy Chiang <andychiang.git@outlook.com>

For more details, see the full job log.

Something broken? Consider providing feedback.

@ckorber
Copy link
Copy Markdown
Contributor

ckorber commented May 11, 2026

Ah, my bad!
I forgot about that. I tested @AndyChiang888 's change and it works now when input is null.

@feckert
Copy link
Copy Markdown
Member

feckert commented May 11, 2026

@systemcrash Works as expected. Thanks.

@AndyChiang888 Please make CI/CD happy :-)

@AndyChiang888
Copy link
Copy Markdown
Author

My email address changed, so CI/CD failed. I'll fix it.

fix "null" text appearing in modal

Signed-off-by: Andy Chiang <AndyChiang_git@outlook.com>
@jow-
Copy link
Copy Markdown
Contributor

jow- commented May 11, 2026

Maybe just [ progress, infonode ?? '' ]

@AndyChiang888
Copy link
Copy Markdown
Author

Will using '' cause DOM rendering issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants